Fix 500 error due to None data in DAB response #15562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relrod
approved these changes
Sep 30, 2024
|
fosterseth
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We had a report from server errors from the
service-index/validate-local-account/endpoint, but I was really grasping for a reproducer. The mechanic was specific to interaction of DAB views with AWX generic views. Because of this, I really wanted some form of coverage for the scenario.It took me a little bit but I finally got this test with I feel fairly satisfied with. Yes, it is mostly a lazy copy of the existing test from DAB, but since AWX is configured differently from test_app in defaults, some differences remain.
This test lets me feel a little bit better about how the server error is fixed. And it's a good thing, because otherwise I would have assumed
response.datais a dictionary, and it wasn't!ISSUE TYPE
COMPONENT NAME