Allow local edits if RESOURCE_SERVER not defined #15545
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is a minor modification to simplify the complexity of settings that someone has to manage. We made similar changes to DAB, such that if
RESOURCE_SERVERis not defined, it doesn't give unreasonable behavior.With this change,
ALLOW_LOCAL_RESOURCE_MANAGEMENTis basically ignored if noRESOURCE_SERVERis defined. This prevents needing to re-define both in the layers of settings override. Still a proposal as of opening this.ISSUE TYPE
COMPONENT NAME