Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload the test results for awx-collection to dashboard #15543

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

jessicamack
Copy link
Member

SUMMARY

We're currently uploading all results under AWX and awx-collections should be tracked separately.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other
AWX VERSION

ADDITIONAL INFORMATION

the rest of the tests can stay under awx
Copy link

sonarcloud bot commented Sep 20, 2024

@jessicamack jessicamack merged commit 7db7abc into ansible:devel Sep 20, 2024
28 of 33 checks passed
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Got one style suggestion, though.

- name: awx-collection
command: /start_tests.sh test_collection_all
coverage-upload-name: "awx-collection"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In other places, the strings are unquoted, it'd be nice to follow the surrounding style:

Suggested change
coverage-upload-name: "awx-collection"
coverage-upload-name: awx-collection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants