Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sonar: skip checking unproblematic files and lines #15487

Closed
wants to merge 1 commit into from
Closed

sonar: skip checking unproblematic files and lines #15487

wants to merge 1 commit into from

Conversation

pb82
Copy link
Contributor

@pb82 pb82 commented Sep 4, 2024 •
edited
Loading

SUMMARY

Sonar reports two high severity security issues. However, they come from script files for bypassing certificate checks. They are not relevant for running AWX.

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API
AWX VERSION
ADDITIONAL INFORMATION

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

TheRealHaoLiu
TheRealHaoLiu requested changes Sep 6, 2024
View reviewed changes
Copy link
Member

@TheRealHaoLiu TheRealHaoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I marked both of the issue acceptable in sonar

Lets not go down the path of polluting our code with bunch of # NOSONAR comments

@pb82 pb82 closed this Sep 11, 2024
@pb82 pb82 deleted the AAP-29543 branch September 11, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealHaoLiu TheRealHaoLiu TheRealHaoLiu requested changes

Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pb82 @TheRealHaoLiu