Fallback to use subscription cred for analytic upload #15479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fall back to use SUBSCRIPTION_USERNAME/PASSWORD to upload analytic to if REDHAT_USERNAME/PASSWORD are not set
TheRealHaoLiu
force-pushed
the
fallback-to-subscription-userpass-for-analytic
branch
from
d7ea02b
to
b32730b
Compare
matburt
reviewed
Aug 29, 2024
TheRealHaoLiu
force-pushed
the
fallback-to-subscription-userpass-for-analytic
branch
from
bda2f63
to
a8b09af
Compare
Focus on credentials
TheRealHaoLiu
force-pushed
the
fallback-to-subscription-userpass-for-analytic
branch
from
a8b09af
to
9c28ac0
Compare
|
Added test please rereview |
TheRealHaoLiu
force-pushed
the
fallback-to-subscription-userpass-for-analytic
branch
from
f4ff88c
to
65e15a5
Compare
|
|
thanks @TheRealHaoLiu and @matburt , will merge and backport |
fosterseth
pushed a commit
to fosterseth/awx
that referenced
this pull request
Aug 30, 2024
…ansible#6668) * Fallback to use subscription cred for analytic Fall back to use SUBSCRIPTION_USERNAME/PASSWORD to upload analytic to if REDHAT_USERNAME/PASSWORD are not set * Improve error message * Guard against request with no query or data * Add test for _send_to_analytics Focus on credentials * Supress sonarcloud warning about password * Add test for analytic ship Co-authored-by: Hao Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fall back to use SUBSCRIPTION_USERNAME/PASSWORD to upload analytic to if REDHAT_USERNAME/PASSWORD are not set
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION