Fix SAMLAuth backend to correctly return social auth pipeline results #15457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newswangerd
force-pushed
the
fix/service-backed-sso
branch
from
01ee568
to
9b7b6cd
Compare
relrod
approved these changes
Aug 21, 2024
|
AlanCoding
approved these changes
Aug 28, 2024
fosterseth
pushed a commit
to fosterseth/awx
that referenced
this pull request
Aug 30, 2024
kdelee
pushed a commit
that referenced
this pull request
Sep 4, 2024
…#15457) (#6669) Co-authored-by: David Newswanger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Social auth pipeline stages are intended to be able to return HTTP response objects such as redirects (https://python-social-auth.readthedocs.io/en/latest/developer_intro.html#interrupting-the-pipeline-and-communicating-with-views). This feature was broken by overriding the
authenticatemethod on the SAMLAuth.Related: ansible/django-ansible-base#565
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION