Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show pre-commit bot vs command line conflict #22

Closed

Conversation

chrismeyersfsu
Copy link
Member

@chrismeyersfsu chrismeyersfsu commented Aug 28, 2024

Running tox -e pre-commit does not reformat the code. Let's see what the bot does.

@chrismeyersfsu chrismeyersfsu force-pushed the show-pre-commit-mismatch branch 2 times, most recently from c67e817 to f621c10 Compare August 28, 2024 13:25
@chrismeyersfsu
Copy link
Member Author

Hmm, seems I was wrong. Closing this.

@webknjaz
Copy link
Member

@chrismeyersfsu there was a case when two runs of pre-commit were needed to settle the formatting between several tools. In that case, the pre-commit.ci bot would send the first formatting update but not the following one, not reacting to its own commit (GitHub Apps normally do this to prevent infinite loops where they trigger themselves).

I handled this manually once, which is why you're no longer seeing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants