-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add write_exclude_list config option #4256
base: main
Are you sure you want to change the base?
Add write_exclude_list config option #4256
Conversation
It might be helpful if someone with the required permissions would add the 'enhancement' label so the test have a chance to run. As far as i can see, I can't do that myself. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests using the exclude list, including one that covers https://github.com/ansible/ansible-lint/pull/4256/files#diff-bbe37334f229af898f52a3ec76e32c5e43c8f2fec8640764775370e6202aa360R154 will be needed.
As this isn't a priority for us at the moment, it will probably take a while until I get to this but it is still on my ToDo list. |
3157021
to
788fa90
Compare
788fa90
to
4cfa695
Compare
4cfa695
to
c84f660
Compare
c84f660
to
4aa5c19
Compare
4aa5c19
to
966e69e
Compare
966e69e
to
587135d
Compare
587135d
to
34b8b75
Compare
I added some basic tests for the new config option. For some reason there is a license test failing for some of the older python versions but I don't really know why. |
@frq-asgard-josi rebase your change, it should address the current failures. Apparently you do not allow us to update the branch ourselves. (see bottom of the right column for that permission on PR page) |
d65da4d
to
b0e39fd
Compare
b0e39fd
to
5ea6d8d
Compare
5ea6d8d
to
c11965a
Compare
c11965a
to
781edd5
Compare
781edd5
to
42f1b7a
Compare
I couldn't find the option to give you permission for that. This might be because the repository isn't owned by me but my organization? Anyway, I rebased my changes to include recent changes to main and fixed remaining errors so this should be ready for review :) |
As proposed here (#4236), we would like to exclude specific rules from the write_list via config file, without automatically applying auto-fixes each time ansible-lint is executed.
This PR provides a possible solution for this (while being fully backwards compatible) by introducing a new config key.