Include ! as a shell word. closes #4386 (#4403)

ansible · Nov 14, 2024 · 2e5af42 · 2e5af42
1 parent 44be233
commit 2e5af42
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/examples/playbooks/rule-command-instead-of-shell-pass.yml b/examples/playbooks/rule-command-instead-of-shell-pass.yml
@@ -58,3 +58,8 @@
           set -x
           ls foo?
       changed_when: false
+
+    - name: Use ! for negation
+      ansible.builtin.shell:
+        cmd: "! crontab -l"
+      changed_when: false
diff --git a/src/ansiblelint/rules/command_instead_of_shell.py b/src/ansiblelint/rules/command_instead_of_shell.py
@@ -69,7 +69,7 @@ def matchtask(
                 return False
 
             jinja_stripped_cmd = self.unjinja(get_cmd_args(task))
-            return not any(ch in jinja_stripped_cmd for ch in "&|<>;$\n*[]{}?`")
+            return not any(ch in jinja_stripped_cmd for ch in "&|<>;$\n*[]{}?`!")
         return False
 
     def transform(