Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Network Integration Action #30

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Network Integration Action #30

wants to merge 2 commits into from

Conversation

roverflow
Copy link

Summary

This PR adds the network integration workflow to the ansible-content-actions repo, this also adds some modifications to the workflow itself

Changes

Adds an extra task that installs the required dependencies

KB-perByte
KB-perByte approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@KB-perByte KB-perByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from a workflow standpoint!

@KB-perByte KB-perByte added the enhancement New feature or request label Oct 15, 2024
KB-perByte
KB-perByte requested changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@KB-perByte KB-perByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roverflow address the CI failures, before you merge it.

@ssbarnea ssbarnea changed the title Network Integration Action Add Network Integration Action Oct 16, 2024
ssbarnea
ssbarnea requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some self-testing action, without it we have zero confidence that the content of this action would be usable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea requested changes

@KB-perByte KB-perByte KB-perByte requested changes

@NilashishC NilashishC Awaiting requested review from NilashishC NilashishC is a code owner

@Qalthos Qalthos Awaiting requested review from Qalthos Qalthos is a code owner automatically assigned from ansible/devtools

@audgirka audgirka Awaiting requested review from audgirka audgirka is a code owner automatically assigned from ansible/devtools

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roverflow @ssbarnea @KB-perByte