Update test cases for AAP-32080 #1327
Conversation
| @@ -474,6 +474,7 @@ def get_model_id( | |||
| organization_id: Optional[int] = None, | |||
| requested_model_id: str = "", | |||
| ) -> str: | |||
| logger.debug(f"requested_model_id={requested_model_id}") | |||
There was a problem hiding this comment.
This is a new log line used only for testing.
|
Sorry @TamiTakamiya I finally got around to look at this and it now has a merge conflict. |
| lambda: None, | ||
| None, | ||
| ) | ||
| self.assertInLog("requested_model_id=mymodel", log) |
There was a problem hiding this comment.
This is a bit overkill IMO since it doesn't really improve the quality of the code and it's testing a behaviour that is obvious.
There was a problem hiding this comment.
Before AAP-32080, Explanations/Generation views did not specify requested_model_id when they call wca_client's get_model_id command. I agree it looks obvious, but this line ensures the requested_model_id is set as expected.
There was a problem hiding this comment.
I agree with @TamiTakamiya whilst the test may be an overkill it does detect and protect against a known issue.
However, I do struggle with these tests and the changes you made to support them. This class tests the view and it should be enough to ensure we call ModelMeshClient's method with the correct model_id. I'd then have tests for WCAClient that check the correct model_id is used e.g. https://github.com/ansible/ansible-ai-connect-service/blob/main/ansible_ai_connect/ai/api/model_client/tests/test_wca_client.py#L1259-L1264
There was a problem hiding this comment.
I know we've probably spent more time discussing these tests than they warrant.
I just think they smell weird.
There was a problem hiding this comment.
@goneri What do you think? I am open to remove this line.
TamiTakamiya
force-pushed
the
TamiTakamiya/AAP-32080/test-case-updates
branch
from
399eddd
to
c309463
Compare
|
Jira Issue: https://issues.redhat.com/browse/AAP-32080
Description
Updates test cases based on the comments I got for #1326. Except for one line to add a log at DEBUG level, all changes are in test codes.
Testing
Steps to test
Scenarios tested
This is a PR on test cases.
Production deployment