Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ospf parser #63

Open
wants to merge 9 commits into
base: devel
Choose a base branch
from
Open

Conversation

willtome
Copy link

@willtome willtome commented Dec 5, 2018

No description provided.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@gdpak
Copy link
Contributor

gdpak commented Dec 10, 2018

@willtome can you please add Signed-off header in your commit . That is why ci is failing.

@willtome
Copy link
Author

@gdpak I'm not sure what that means or how to do that.

@LukeDRussell
Copy link
Contributor

git checkout your-branch
git reset HEAD~1
git commit -m “your message” -s 
git push —force

https://stackoverflow.com/questions/1962094/what-is-the-sign-off-feature-in-git-for

If you have more than one commit you’re probably best off editing the message for each commit. You could also squash your commits into one.

@gdpak
Copy link
Contributor

gdpak commented Dec 19, 2018

@willtome You have commits on your PR without a header "Signed-off-by <>"
please use git commit --amend --signoff <commit-id> to add this header in your PR branch. zuul should pass then.

Signed-off-by: willtome <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@justjais
Copy link
Member

justjais commented Feb 5, 2019

@willtome any update on this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants