Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes remount /tmp typo #93

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Conversation

dderemiah
Copy link
Contributor

Overall Review of Changes:
Fixes capitalization for handler notify
Issue Fixes:
Fixes capitalization for handler notify

Enhancements:

How has this been tested?:
tested on my servers

@uk-bolly
Copy link
Member

hi @dderemiah

Thank you for highlighting this issue and raising the subsequent PR. i have however noticed that the commit is not signed-off by for gpg signed which are requirements as per the contributing guidelines.
If you could fix this i am happy to accept the PR.

Many thanks

uk-bolly

@dderemiah
Copy link
Contributor Author

I followed the directions I could find on signing PR's. Hopefully it worked.

@uk-bolly
Copy link
Member

hi @dderemiah

Thank you for following up on this its almost there, this can be a little confusing. The commit is now signed-off-by but it would still need to be signed.
The following article may help. It also shows how it appears in the PR with the verified logo next to it once it is gpg signed.

https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

many thanks

uk-bolly

@dderemiah
Copy link
Contributor Author

It says the commit is signed. I think I got it done. Thanks

Copy link
Member

@uk-bolly uk-bolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@uk-bolly uk-bolly merged commit 32cbc8f into ansible-lockdown:devel Sep 21, 2023
3 checks passed
@dderemiah dderemiah deleted the typo_fix branch September 21, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants