-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cisco Intersight module generation code added leveraging VMware REST #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first glance, this PR looks good. However, the template files need to be adjusted to enable the creation of the cisco.intersight module.
roles/module_openapi_cloud/templates/module_directory/cisco_intersight/default_module.j2
Outdated
Show resolved
Hide resolved
roles/module_openapi_cloud/templates/module_directory/cisco_intersight/default_module.j2
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me. However, I'm not sure if the generated module files meet your needs, as I haven't tested them.
SUMMARY
Initial Cisco Intersight module generation code leveraging VMware REST
ISSUE TYPE
COMPONENT NAME
Cisco Intersight added to Generate modules
ADDITIONAL INFORMATION
Currently tested with Intersight Server Access Policy schema with model reference at https://intersight.com/apidocs/apirefs/All/access/Policies/model/