Install Enterprise via repo, updated Vault to v1.18.0 #345
+98
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lakrass
commented
Oct 28, 2024
lakrass
commented
- Add ability to install Vaul Enterprise via HashiCorp repo
- Removed check of non-existent variable
- Update Vault to v1.18.0
added 13 commits
October 24, 2024 16:05
sschmittsva
suggested changes
Nov 18, 2024
| @@ -65,18 +65,24 @@ | |||
| name: "{{ vault_rhsm_repo_id }}" | |||
| state: enabled | |||
|
|
|||
| - name: Ensure Enterprise package is not present when OSS is desired and vice versa | |||
| package: | |||
| name: "{{ 'vault' ~ ('-enterprise' if not (vault_enterprise | bool) else '') }}" | |||
| @@ -58,7 +58,7 @@ | |||
| when: | |||
| - vault_enterprise | bool | |||
| - not vault_install_remotely | bool | |||
| - not vault_install_remote_repo | bool | |||
| - not vault_install_hashi_repo | bool | |||
There was a problem hiding this comment.
vault_install_remote_repo does not seem to be used elsewhere. But I'm not sure if we want to remove it in this PR.
| @@ -72,7 +72,6 @@ | |||
| - name: Install Vault via HashiCorp repository | |||
| include_tasks: install_hashi_repo.yml | |||
| when: | |||
| - not vault_enterprise | bool | |||
There was a problem hiding this comment.
Do we really want to remove it here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.