-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging v1.11.1 tasks #1812
Open
fernandofloresg
wants to merge
15
commits into
staging-v1.11.1
Choose a base branch
from
staging-v1.11.1-tasks
base: staging-v1.11.1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Staging v1.11.1 tasks #1812
+92
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandofloresg
changed the base branch from
staging-v1.11.0
to
staging-v1.11.1
November 22, 2024 00:01
fernandofloresg
requested review from
ketankelkar,
ddimatos,
richp405,
rexemin and
AndreMarcel99
and removed request for
ketankelkar and
ddimatos
November 22, 2024 00:04
This shows ansible sanity failing but appears to be an issue with most recent PRs as you can see in the details is not related to the code. Executed it locally and does not fail, also, uploading this to the test servers works fine too. (venv-2.17) ./ac --ac-sanity
-----------------------------------------------------------------------
Running ansible-test with managed python virtual environment: /Users/fernandoflores/Documents/IBM/Repos/ibm_zos_core/venv/venv-2.17.
-----------------------------------------------------------------------
Running sanity test "action-plugin-docs"
Running sanity test "ansible-doc"
Running sanity test "changelog"
Running sanity test "compile" on Python 3.12
Running sanity test "empty-init"
Running sanity test "ignores"
Running sanity test "import" on Python 3.12
Running sanity test "line-endings"
Running sanity test "no-assert"
Running sanity test "no-get-exception"
Running sanity test "no-illegal-filenames"
Running sanity test "no-smart-quotes"
Running sanity test "pep8"
Running sanity test "pslint"
Running sanity test "pylint"
Running sanity test "replace-urlopen"
Running sanity test "runtime-metadata"
Running sanity test "shebang"
Running sanity test "shellcheck"
Running sanity test "symlinks"
Running sanity test "use-argspec-type-path"
Running sanity test "use-compat-six"
Running sanity test "validate-modules"
Running sanity test "yamllint"
|
rexemin
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just noticed one wrong link
rexemin
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Review release tasks for v1.11.1, this typically are reviewed in the merge against main, but since this is just a patch then this is just to have an extra set of eyes on this.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION