[Enhancement] [zos_job_submit] Async support for zos_job_submit #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results for Jenkins. First, zos_job_submit by itself, then the rest of the modules affected by the change.
|
rexemin
requested review from
ketankelkar,
fernandofloresg,
ddimatos,
richp405 and
AndreMarcel99
fernandofloresg
requested changes
Nov 15, 2024
plugins/action/zos_job_submit.py
Outdated
|
|
||
| if remote_path: | ||
| self._fixup_perms2((tmp, remote_path)) | ||
| # remote_path = None |
There was a problem hiding this comment.
These can be removed rather than commented
plugins/action/zos_job_submit.py
Outdated
|
|
||
| tmp_src = self._connection._shell.join_path(tmp, "source") | ||
| # tmp_src = self._connection._shell.join_path(tmp, "source") |
There was a problem hiding this comment.
these can be removed too
| assert result.stderr == "" | ||
|
|
||
| finally: | ||
| os.remove("inventory.yml") |
There was a problem hiding this comment.
wondering if these two could have been NamedTemporaryFiles ?
There was a problem hiding this comment.
Yes, they can be, and here's the Jenkins pipeline testing that change
|
|
||
| - name: Query async task. | ||
| async_status: | ||
| jid: "{{{{ job_task.ansible_job_id }}}}" |
There was a problem hiding this comment.
Can you share how a non async status would fail in this case?
AndreMarcel99
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #1249 and #1748.
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
In the end, zos_copy was not needed to be changed, zos_job_submit's action plugin can run zos_copy and block the rest of the execution flow until the local JCL file is uploaded to the remote host.