-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update default proxysql version, drop support for xenial (EOL) and fix small bugs #92
Conversation
…-and-correct-package-name.yml
Codecov Report
@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage 72.97% 72.97%
=======================================
Files 10 10
Lines 1199 1199
Branches 193 193
=======================================
Hits 875 875
Misses 246 246
Partials 78 78 Continue to review full report at Codecov.
|
changelogs/fragments/89-dynamic-user-password-in-client-my-cnf-and-correct-package-name.yml
Outdated
Show resolved
Hide resolved
Works also for me on Ubuntu 18.04 and 20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we say that the role requires Python3 since now? Wouldn't it be a breaking change? (i don't remember the context of the PR)
@@ -21,7 +21,7 @@ jobs: | |||
strategy: | |||
matrix: | |||
proxysql: | |||
- 2.0.12 | |||
- 2.3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 2.3.2 | |
- 2.3.2 |
I would suggest having at least the oldest version of proxysql supported by the collection and the latest one there (no need to add now, just an idea)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's something we can place/add to this issue #75 :)
I think it is a natural thing, because the installation role supports just ubuntu 16.04 and 18.04 until now: https://github.com/ansible-collections/community.proxysql/blob/main/roles/proxysql/meta/main.yml And after dropping 16.04 (because it is EOL since arpil 2021), there is no need to take care about python2 anymore in Ubuntu 18.04 and 20.04. |
...and Ubuntu 22.04 is knocking the door. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markuman thanks for clarifying, the PR LGTM
Hi all,
This PR contain changes:
mysql-default_sql_mode
,mysql-default_time_zone
,mysql-forward_autocommit
. Ref: https://proxysql.com/documentation/global-variablesset_fact
I tested on Ubuntu 18 and Ubuntu 20. It works well