-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing gtid_port to proxysql_backend_servers module #118
base: main
Are you sure you want to change the base?
Conversation
gtid_port: | ||
description: | ||
- The backend server port where ProxySQL Binlog Reader listens on for GTID tracking | ||
type: int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gtid_port: | |
description: | |
- The backend server port where ProxySQL Binlog Reader listens on for GTID tracking | |
type: int | |
gtid_port: | |
description: | |
- The backend server port where ProxySQL Binlog Reader listens on for GTID tracking | |
type: int | |
version_added: 1.5.0 |
It should also be mentioned in the description, that the default value is 0
, even if it's not set by the ansible module.
gtid_port INT CHECK ((gtid_port <> port OR gtid_port=0) AND gtid_port >= 0 AND gtid_port <= 65535) NOT NULL DEFAULT 0,
@thanos-k Thanks for the quick PR. You can try to expand the existing test: https://github.com/ansible-collections/community.proxysql/tree/main/tests/integration/targets/test_proxysql_backend_servers/tasks, but it's difficult to see through. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thanos-k thanks for the PR!
bugfixes: | ||
- modules/proxysql_backend_servers - Added missing gtid_port to proxysql_backend_servers module (https://github.com/ansible-collections/community.proxysql/pull/118). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bugfixes: | |
- modules/proxysql_backend_servers - Added missing gtid_port to proxysql_backend_servers module (https://github.com/ansible-collections/community.proxysql/pull/118). | |
minor_changes: | |
- proxysql_backend_servers - Added missing ``gtid_port`` argument to the module (https://github.com/ansible-collections/community.proxysql/pull/118). |
@thanos-k @markuman I think it should be of the minor_changes:
category as it adds a new argument.
SUMMARY
Added missing gtid_port to proxysql_backend_servers module
Fixes #117
ISSUE TYPE
COMPONENT NAME
modules/proxysql_backend_servers