Fixed connection with proxmox without certs #9178
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
added
check-before-release
|
Thanks for your contribution! Can you please add a changelog fragment? Thanks. |
t-pierre
force-pushed
the
proxmox-validate_certs
branch
from
6f7933b
to
8cb1fb8
Compare
changelogs/fragments/9178-fix-proxmox-connection-without-certs.yml
Outdated
Show resolved
Hide resolved
| @@ -312,7 +312,7 @@ def _get_json(self, url, ignore_errors=None): | |||
| data = [] | |||
| s = self._get_session() | |||
| while True: | |||
| ret = s.get(url, headers=self.headers) | |||
| ret = s.get(url, headers=self.headers, verify=s.verify) | |||
There was a problem hiding this comment.
Which version of requests do you have that needs this? self._get_session() returns a requests.Session object with verify set, which according to the documentation (and the requests sources) should apply to all requests made with this session. So the change should not really have any effect. If it has an effect for you, I think we should first try to find out why that is the case.
There was a problem hiding this comment.
I have requests 2.32.3 and python 3.12. I'm on mac, if it's important
There was a problem hiding this comment.
It works on a lxc.
On macOS Sequoia 15.1.1: ❌
ansible --version
ansible [core 2.18.0]
config file = /Users/*user*/Desktop/*project*/ansible.cfg
configured module search path = ['/Users/*user*/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/Cellar/ansible/11.0.0/libexec/lib/python3.13/site-packages/ansible
ansible collection location = /Users/*user*/.ansible/collections:/usr/share/ansible/collections
executable location = /usr/local/bin/ansible
python version = 3.13.0 (main, Oct 7 2024, 05:02:14) [Clang 16.0.0 (clang-1600.0.26.4)] (/usr/local/Cellar/ansible/11.0.0/libexec/bin/python)
jinja version = 3.1.4
libyaml = True
On pipenv: ❌
ansible [core 2.18.0]
config file = /Users/*user*/Desktop/*project*/ansible.cfg
configured module search path = ['/Users/*user*/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /Users/*user*/Desktop/*project*/lib/python3.12/site-packages/ansible
ansible collection location = /Users/*user*/.ansible/collections:/usr/share/ansible/collections
executable location = /Users/*user*/Desktop/*project*/bin/ansible
python version = 3.12.7 (main, Oct 1 2024, 02:05:46) [Clang 15.0.0 (clang-1500.3.9.4)] (/Users/*user*/Desktop/*project*/bin/python3.12)
jinja version = 3.1.4
libyaml = True
On a Debian GNU/Linux 11 (bullseye) lxc: ✅
ansible --version
ansible [core 2.15.12]
config file = /root/*project*/ansible.cfg
configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /root/.local/lib/python3.9/site-packages/ansible
ansible collection location = /root/.ansible/collections:/usr/share/ansible/collections
executable location = /usr/bin/ansible
python version = 3.9.2 (default, Feb 28 2021, 17:03:44) [GCC 10.2.1 20210110] (/usr/bin/python3)
jinja version = 3.1.4
libyaml = True
Tell me what information you need
Thanks!
….yml Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Need to add the verify argument to the get() call to successfully connect to a proxmox without a certificate.
Without it, the validate_certs parameter in proxmox.yml inventory seems to be ignored (not really used, at least).
ISSUE TYPE
COMPONENT NAME
plugins/inventory/proxmox.py