Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decompress module #9175
base: main
Are you sure you want to change the base?
Add decompress module #9175
Changes from 22 commits
29705f0
ecac887
0473131
f9ff4cd
b17d344
a2c85c6
a578fba
9580084
8db0256
21f301d
a5bfe90
36bd421
c7b6e48
c5a2214
4816b8f
203312b
89cd527
3e4a174
ee9f58c
c6e7961
eba3564
7774900
9e34fb1
ef683c1
85a0765
52b3f57
51b31ee
cbcd66c
3fbcbd4
8210a7c
e5917cc
e2c94ab
d2d9159
28752e3
ae8db2b
e68936b
893b92a
bab6620
6e7fed0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to consider using
module_utils.deps
, see https://docs.ansible.com/ansible/latest/collections/community/general/docsite/guide_deps.html for guidance on how to use it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might want to consider using
ModuleHelper
. See more in https://docs.ansible.com/ansible/latest/collections/community/general/docsite/guide_modulehelper.htmlThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect that
b_
indicates bytes, and not native. Why not use byte strings? That's usually the better choice for filesystem paths.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case
remove=true
and the destination path exists, but the source path does not exist, the module should not fail, but simply exit withchanged=false
. Otherwise the module isn't idempotent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format is controlled by the module parameter, so it is always supposed to have a handler. This code is redundant.