Fix nxos_user purge deleting non-locally configured users. #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAYUSH2091
changed the title
|
@AAYUSH2091 can you please add unit tests to validate the changes? |
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes an issue in the nxos_user module where the purge option deleting the non-locally configured users displayed by the "show user-account" command, breaking idempotency. Now, only locally configured users are purged.
Fixes #871
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
nxos_user
ADDITIONAL INFORMATION
When the purge option was used, users authenticated via TACACS+ or users defined for SNMP were being deleted despite not being locally configured. This fix ensures only local users are purged.