static_routes - Ensure idempotency with encapsulated interfaces (e.g TenGigE0/0/0/23.1234) #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TenGigE0/0/0/23.1234)
tweippert
approved these changes
Sep 30, 2024
|
Any news on status here? Will this move to next release? |
hey @weippertt can you please add an integration test as well to validate this change? |
Currently i try to figure out how to add the proper integration tests and also how to test them in advance, but i have not found the correct answers yet. any hints are welcome. |
|
@Ruchip16 is the integration test added valid and enough for merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Static Routes with encapsulated Interfaces seems not idempotent, this adds the regex to
recognise also interfaces with . in the name
ISSUE TYPE
COMPONENT NAME
static_routes
ADDITIONAL INFORMATION
idempotency with static_routes on encapsulated interfaces