Bug453 port group

[ntl-afzaalarif]

SUMMARY

The iosxr acls module was wrongly setting port-group param to be mutually exclusive with net-group,host,address,any and prefix in source and destination of ACE. The following ACE was correct and was a part of ACL on cisco ios xr9k series router. 1390 permit udp any 1.1.1.1 0.0.0.0 port-group ABC

As can be seen the [address(1.1.1.1), wildcard(0.0.0.0)] and port-group(ABC) are placed together, which as per previously implemented logic of iosxr.acls ansible module was inconsistent and should be mutually exclusive.

I have modified the iosxr.acls module to now fix this problem, moreover removed the port-group as direct option to the source/destination and moved it under the port_protocol options. Also updated the ansible-doc for it.

This fixes #453

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

cisco.iosxr.iosxr_acls

ADDITIONAL INFORMATION

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/9dc7b882352d40cabf790766ea781dec

✔️ ansible-galaxy-importer SUCCESS in 5m 06s
✔️ build-ansible-collection SUCCESS in 10m 07s
❌ ansible-tox-linters FAILURE in 12m 08s

[ashwini-mhatre]

@ntl-afzaalarif please add uts and integration tests

[ntl-afzaalarif]

Hi @ashwini-mhatre, this is my first PR. Just noticed a bug and wanted to highlight. Can you please guide on how to add uts and integration tests?

[roverflow]

Hey @ntl-afzaalarif, i can see there are a few changes present, thanks for contributing, it would be amazing if you could make changes according to the CONTRIBUTION guidelines that we follow

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/8198f828b01e4777a6dca43c22084311

✔️ ansible-galaxy-importer SUCCESS in 5m 09s
✔️ build-ansible-collection SUCCESS in 9m 51s
❌ ansible-tox-linters FAILURE in 12m 04s

[ashwini-mhatre]

@ntl-afzaalarif please refer following file for uts https://github.com/ansible-collections/cisco.iosxr/blob/main/tests/unit/modules/network/iosxr/test_iosxr_acls.py

[ashwini-mhatre]

@ntl-afzaalarif please refer following directory for inegration tests https://github.com/ansible-collections/cisco.iosxr/tree/main/tests/integration/targets/iosxr_acls/tests/cli

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/22e29bffda2a4892ae7eb8d50a48f70d

✔️ ansible-galaxy-importer SUCCESS in 3m 30s
✔️ build-ansible-collection SUCCESS in 10m 35s
❌ ansible-tox-linters FAILURE in 12m 53s

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e8221481ccf14f2391d5658261ae8c71

✔️ ansible-galaxy-importer SUCCESS in 5m 14s
✔️ build-ansible-collection SUCCESS in 10m 12s
❌ ansible-tox-linters FAILURE in 11m 54s

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/f4566772ce104ade83f51ad63fd7bccd

✔️ ansible-galaxy-importer SUCCESS in 4m 25s
✔️ build-ansible-collection SUCCESS in 9m 50s
❌ ansible-tox-linters FAILURE in 12m 03s

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/5d7462aba868490fbdb93fa27ad5418a

✔️ ansible-galaxy-importer SUCCESS in 4m 09s
✔️ build-ansible-collection SUCCESS in 10m 17s
❌ ansible-tox-linters FAILURE in 12m 03s

[github-actions]

Label error. Requires exactly 1 of: bug, enhancement, major, minor, patch, skip-changelog. Found:

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/74e27d027a88444a884c6f9403e2de48

❌ ansible-galaxy-importer RETRY_LIMIT in 7m 05s
✔️ build-ansible-collection SUCCESS in 9m 37s
❌ ansible-tox-linters FAILURE in 11m 53s

[softwarefactory-project-zuul]

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/e51d914861ef4fc2b9f6b7e47e1fe99b

✔️ ansible-galaxy-importer SUCCESS in 3m 19s
✔️ build-ansible-collection SUCCESS in 10m 33s
❌ ansible-tox-linters FAILURE in 12m 42s