Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bgp_address_family] fix remote_as #933

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

KB-perByte
Copy link
Collaborator

SUMMARY

This should go by a deprecation cycle and a new attribute needs to be introduced here as str
Keeping the options in draft.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

bgp_address_family

ADDITIONAL INFORMATION

@KB-perByte KB-perByte added blocks_release Ensure this is merged before a release is made. bug This issue/PR relates to a bug. bgp_address_family bgp_address_family resource module labels Sep 26, 2023
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack September 26, 2023 08:03 Inactive
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #933 (9045fb5) into main (f8cc93a) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #933   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         184      184           
  Lines       11926    11930    +4     
=======================================
+ Hits        10246    10250    +4     
  Misses       1680     1680           

see 1 file with indirect coverage changes

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ad3965c5f16446efab1a2edfad3bb429

✔️ ansible-galaxy-importer SUCCESS in 4m 50s
✔️ build-ansible-collection SUCCESS in 8m 36s
ansible-ee-integration-ios-latest FAILURE in 13m 38s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 58s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 13m 41s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 17m 30s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 17m 30s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 17m 03s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 16m 05s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 12m 09s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 18s

@KB-perByte KB-perByte temporarily deployed to ack October 5, 2023 08:03 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e5857f2c6970434a8f72fb1681aa8cff

✔️ ansible-galaxy-importer SUCCESS in 6m 19s
✔️ build-ansible-collection SUCCESS in 8m 43s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 38s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 12m 32s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 38s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 20s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 20s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 02s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 18s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 12s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 09s

@KB-perByte KB-perByte temporarily deployed to ack October 5, 2023 09:19 — with GitHub Actions Inactive
@KB-perByte KB-perByte merged commit 77b65ad into ansible-collections:main Oct 5, 2023
@KB-perByte KB-perByte deleted the remote_as_bgp_af branch October 9, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bgp_address_family bgp_address_family resource module blocks_release Ensure this is merged before a release is made. bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ansible (cisco.ios.ios_facts) does not support the use of BGP AS numbers in dot format.
1 participant