Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error parser not recognizing % Invalid #931

Merged
merged 7 commits into from
Oct 25, 2023

Conversation

roverflow
Copy link
Member

@roverflow roverflow commented Sep 25, 2023

SUMMARY

Fixes % Invalid password length error not being recognized

For issue #925

Playbook used for testing:

---
- name: IOS user
  hosts: ios
  gather_facts: false
  tasks:
    - name: Test user
      cisco.ios.ios_user:
        aggregate:
          - name: testuser
            configured_password: "password length 128"
            sshkey: "{{ lookup('file', '/home/test/test.pub') }}"
        privilege: 15
        password_type: secret
        update_password: on_create
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • ios_user

@roverflow roverflow temporarily deployed to ack September 25, 2023 14:58 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/fe3354f6718143adae1bdf7a39cc7b12

✔️ ansible-galaxy-importer SUCCESS in 5m 05s
✔️ build-ansible-collection SUCCESS in 9m 13s
ansible-ee-integration-ios-latest FAILURE in 14m 09s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 39s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 14m 02s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 12m 57s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 12m 09s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 32s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 13m 40s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 57s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 11s

@roverflow roverflow temporarily deployed to ack October 12, 2023 08:26 — with GitHub Actions Inactive
@roverflow roverflow temporarily deployed to ack October 12, 2023 08:39 — with GitHub Actions Inactive
@roverflow roverflow changed the title [WIP] Fixes ios_user command generation [WIP] Fixes error parser not recognizing % Invalid Oct 12, 2023
@roverflow roverflow changed the title [WIP] Fixes error parser not recognizing % Invalid Fixes error parser not recognizing % Invalid Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #931 (b2d2915) into main (a787b3b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #931   +/-   ##
=======================================
  Coverage   85.89%   85.89%           
=======================================
  Files         184      184           
  Lines       11938    11938           
=======================================
  Hits        10254    10254           
  Misses       1684     1684           

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/680d21ac51444dc2911944409092b02e

✔️ ansible-galaxy-importer SUCCESS in 4m 11s
✔️ build-ansible-collection SUCCESS in 8m 41s
ansible-ee-integration-ios-latest RETRY_LIMIT in 2m 59s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 25s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 21s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 24s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 03s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 28s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 01s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 24s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 10s

@roverflow roverflow temporarily deployed to ack October 12, 2023 09:50 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/45619841d22d4b288abd51cdfb591eaa

✔️ ansible-galaxy-importer SUCCESS in 8m 35s
✔️ build-ansible-collection SUCCESS in 8m 53s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 20s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 17s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 18s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 31s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 2m 57s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 53s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 06s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 21s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 12s

@roverflow roverflow temporarily deployed to ack October 17, 2023 13:14 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/27a95e2fc24c46d0bc6fbfc8442c7967

✔️ ansible-galaxy-importer SUCCESS in 9m 20s
✔️ build-ansible-collection SUCCESS in 8m 48s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 35s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 02s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 2m 59s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 2m 58s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 28s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 34s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 02s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 31s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 15s

@KB-perByte KB-perByte temporarily deployed to ack October 25, 2023 10:02 — with GitHub Actions Inactive
@KB-perByte KB-perByte merged commit bbfdcbd into ansible-collections:main Oct 25, 2023
50 of 51 checks passed
@roverflow roverflow deleted the ios_user_fix branch November 7, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants