Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[acls] fixes aces rendering, overridden and replaced state operations. #929

Merged
merged 23 commits into from
Sep 22, 2023

Conversation

KB-perByte
Copy link
Collaborator

@KB-perByte KB-perByte commented Sep 18, 2023

SUMMARY

Fixes rendering of standard acls
Fixes rendering of protocol_option attribute makes action states stable.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ios_acls

ADDITIONAL INFORMATION

@pre-commit-ci pre-commit-ci bot temporarily deployed to ack September 18, 2023 09:25 Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/7bb57e4a95de4a74beaa162ce82eac26

✔️ ansible-galaxy-importer SUCCESS in 3m 24s
✔️ build-ansible-collection SUCCESS in 8m 43s
ansible-ee-integration-ios-latest FAILURE in 13m 55s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 54s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 14m 26s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 14m 06s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 14m 53s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 36s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 14m 16s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 20s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 18s

@KB-perByte KB-perByte temporarily deployed to ack September 18, 2023 11:17 — with GitHub Actions Inactive
@KB-perByte KB-perByte temporarily deployed to ack September 18, 2023 11:35 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #929 (1552c47) into main (fefe151) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #929   +/-   ##
=======================================
  Coverage   85.90%   85.91%           
=======================================
  Files         184      184           
  Lines       11925    11926    +1     
=======================================
+ Hits        10244    10246    +2     
+ Misses       1681     1680    -1     

see 2 files with indirect coverage changes

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d8f6849d8a4c4bf48cddcb88798468c1

✔️ ansible-galaxy-importer SUCCESS in 5m 02s
✔️ build-ansible-collection SUCCESS in 8m 44s
ansible-ee-integration-ios-latest FAILURE in 15m 58s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 16m 40s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 15m 29s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 16m 37s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 16m 42s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 16m 18s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 17m 20s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 01s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 11s

@KB-perByte KB-perByte temporarily deployed to ack September 18, 2023 12:26 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack September 18, 2023 12:27 Inactive
@KB-perByte KB-perByte temporarily deployed to ack September 18, 2023 12:37 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/121028d25f3546bdb708a9c90018a495

✔️ ansible-galaxy-importer SUCCESS in 4m 09s
✔️ build-ansible-collection SUCCESS in 8m 44s
ansible-ee-integration-ios-latest FAILURE in 25m 17s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 53s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 29m 41s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 29m 49s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 27m 22s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 29m 18s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 29m 25s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 14m 03s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 16s

@KB-perByte KB-perByte temporarily deployed to ack September 18, 2023 14:18 — with GitHub Actions Inactive
@KB-perByte KB-perByte temporarily deployed to ack September 18, 2023 14:23 — with GitHub Actions Inactive
@KB-perByte KB-perByte temporarily deployed to ack September 18, 2023 14:27 — with GitHub Actions Inactive
@KB-perByte KB-perByte added bug This issue/PR relates to a bug. docs Documentation related changes labels Sep 18, 2023
@KB-perByte KB-perByte temporarily deployed to ack September 18, 2023 14:28 — with GitHub Actions Inactive
@KB-perByte KB-perByte temporarily deployed to ack September 20, 2023 05:55 — with GitHub Actions Inactive
@KB-perByte KB-perByte temporarily deployed to ack September 20, 2023 06:00 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack September 20, 2023 06:01 Inactive
@KB-perByte KB-perByte temporarily deployed to ack September 20, 2023 06:20 — with GitHub Actions Inactive
@KB-perByte KB-perByte temporarily deployed to ack September 20, 2023 06:58 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/d5d797b9a1b34ac98ae33884b3f71e7e

✔️ ansible-galaxy-importer SUCCESS in 3m 26s
✔️ build-ansible-collection SUCCESS in 9m 01s
ansible-ee-integration-ios-latest FAILURE in 18m 10s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 20m 07s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 19m 50s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 19m 18s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 21m 35s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 23m 35s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 21m 02s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 23m 39s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 30s

@KB-perByte KB-perByte temporarily deployed to ack September 20, 2023 09:39 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/5cda0d24de3d41be99c577a9d0448d29

✔️ ansible-galaxy-importer SUCCESS in 5m 17s
✔️ build-ansible-collection SUCCESS in 8m 45s
ansible-ee-integration-ios-latest FAILURE in 22m 44s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 24m 48s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 21m 42s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 24m 34s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 24m 27s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 24m 05s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 19m 35s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 22m 03s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 10s

@pre-commit-ci pre-commit-ci bot temporarily deployed to ack September 20, 2023 10:58 Inactive
@KB-perByte KB-perByte temporarily deployed to ack September 20, 2023 11:06 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack September 20, 2023 11:07 Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/03c4b218f9e9476c989b1e3b545772c1

✔️ ansible-galaxy-importer SUCCESS in 4m 22s
✔️ build-ansible-collection SUCCESS in 8m 33s
ansible-ee-integration-ios-latest FAILURE in 15m 18s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 16m 02s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 15m 06s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 14m 50s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 19m 04s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 18m 01s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 12m 29s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 34s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 07s

@rohitthakur2590 rohitthakur2590 changed the title [acls] fix aces rendering and overridden and replaced state. [acls] fixes aces rendering, overridden and replaced state operations. Sep 20, 2023
@KB-perByte KB-perByte temporarily deployed to ack September 22, 2023 07:36 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/ea55ce706a6649fabf537541e4f81894

✔️ ansible-galaxy-importer SUCCESS in 4m 29s
✔️ build-ansible-collection SUCCESS in 8m 52s
ansible-ee-integration-ios-latest FAILURE in 12m 27s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 30s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 13m 01s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 15m 35s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 14m 26s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 26s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 15m 45s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 29s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 06s

@KB-perByte KB-perByte merged commit 2001633 into ansible-collections:main Sep 22, 2023
@KB-perByte KB-perByte deleted the acls_issue branch September 22, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug. docs Documentation related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cisco.ios.ios_acls - idempotency
2 participants