Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix 906 #907

Closed
wants to merge 11 commits into from
Closed

Conversation

tnizharadze
Copy link

SUMMARY

Fixes #906

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cisco/ios/plugins/cliconf/ios.py

ADDITIONAL INFORMATION

In some situations module cisco/ios/plugins/cliconf/ios.py does not send "end" command after "configure terminal" command. This patch ensures that in all cases "end" command will be send to device.


@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/509d32e234f242bc94b1d49f27d82415

✔️ ansible-galaxy-importer SUCCESS in 4m 37s
✔️ build-ansible-collection SUCCESS in 9m 10s
ansible-ee-integration-ios-latest FAILURE in 11m 59s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 12m 33s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 12m 58s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 13m 27s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 13m 17s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 06s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 13m 09s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 12s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 39s

@KB-perByte KB-perByte temporarily deployed to ack September 25, 2023 13:36 — with GitHub Actions Inactive
@KB-perByte
Copy link
Collaborator

Hey @tnizharadze could you please add a changelog explaining your changes?
Thank you for your contribution.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc3fa18) 86.80% compared to head (0bc1d13) 86.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #907      +/-   ##
==========================================
- Coverage   86.80%   86.80%   -0.01%     
==========================================
  Files         196      196              
  Lines       12266    12267       +1     
==========================================
  Hits        10648    10648              
- Misses       1618     1619       +1     

see 1 file with indirect coverage changes

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/8a9aeff32fe04a229a41687262464fb1

✔️ ansible-galaxy-importer SUCCESS in 3m 42s
✔️ build-ansible-collection SUCCESS in 8m 38s
ansible-ee-integration-ios-latest FAILURE in 13m 11s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 53s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 18m 09s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 18m 27s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 18m 15s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 18m 36s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 13m 17s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 25s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 05s

@tnizharadze tnizharadze temporarily deployed to ack September 27, 2023 19:09 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack September 27, 2023 19:10 Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e7a8aa28ac87462aba946f901b4d3783

✔️ ansible-galaxy-importer SUCCESS in 4m 38s
✔️ build-ansible-collection SUCCESS in 8m 55s
ansible-ee-integration-ios-latest FAILURE in 17m 35s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 17m 23s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 17m 35s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 17m 24s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 12m 39s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 16m 12s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 15m 14s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 15m 12s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 31s

@KB-perByte KB-perByte temporarily deployed to ack October 25, 2023 10:11 — with GitHub Actions Inactive
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6408863a53494425823407b0c29b5768

✔️ ansible-galaxy-importer SUCCESS in 4m 45s
✔️ build-ansible-collection SUCCESS in 9m 10s
ansible-ee-integration-ios-latest NODE_FAILURE Node request 200-0006545863 failed in 0s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 27m 52s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 5m 45s (non-voting)
ansible-ee-integration-ios-stable-2.12 NODE_FAILURE Node request 200-0006545865 failed in 0s (non-voting)
ansible-ee-integration-ios-libssh-latest NODE_FAILURE Node request 200-0006545866 failed in 0s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 27m 34s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 NODE_FAILURE Node request 200-0006545861 failed in 0s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 NODE_FAILURE Node request 200-0006545859 failed in 0s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 32s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/70685adcf0ce4c0a9e0a1e958ded9e6a

✔️ ansible-galaxy-importer SUCCESS in 5m 06s
✔️ build-ansible-collection SUCCESS in 9m 48s
ansible-ee-integration-ios-latest RETRY_LIMIT in 7m 38s (non-voting)
ansible-ee-integration-ios-stable-2.9 RETRY_LIMIT in 4m 30s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 4m 51s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 29s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 7m 26s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 RETRY_LIMIT in 3m 56s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 4m 05s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 7m 38s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 43s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/69c152284d5a44a38a1f6a6c5bd6cd52

✔️ ansible-galaxy-importer SUCCESS in 4m 43s
✔️ build-ansible-collection SUCCESS in 9m 52s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 30s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 21s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 10s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 08s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 08s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 13m 58s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 25s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 21s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 51s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/c01b74a2e6924b0cb447c7af36cb26a7

✔️ ansible-galaxy-importer SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 9m 51s
ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 57s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 17m 36s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 19m 09s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 17s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 06s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 15s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 4m 43s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 4m 25s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 23s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/80bc3ba2812f4a7895590563588d9c9e

✔️ ansible-galaxy-importer SUCCESS in 4m 40s
✔️ build-ansible-collection SUCCESS in 10m 08s
ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 34s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 14m 39s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 07s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 3m 08s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 4m 15s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 14s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 54s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 11s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 49s

@roverflow roverflow closed this Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cisco.ios.ios_config: wrong commands send to device
3 participants