Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ios_vxlan_vtep resource module #902

Merged

Conversation

PadminiSivaraj
Copy link
Contributor

SUMMARY

Added ios_vxlan_vtep resource module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ios_vxlan_vtep resource module

@softwarefactory-project-zuul
Copy link

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/b52428c69cdf44c49923a5a393720cff

✔️ ansible-galaxy-importer SUCCESS in 5m 35s
✔️ build-ansible-collection SUCCESS in 8m 54s
ansible-ee-integration-ios-latest FAILURE in 11m 37s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 18m 52s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 12m 20s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 12m 25s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 18m 59s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 18m 59s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 18m 42s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 18m 59s (non-voting)
ansible-tox-linters FAILURE in 10m 17s

@KB-perByte KB-perByte added the feature This issue/PR relates to a feature request. label Aug 8, 2023
@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/b3030dc5706f49298ba2941007e76be6

✔️ ansible-galaxy-importer SUCCESS in 4m 07s
✔️ build-ansible-collection SUCCESS in 8m 35s
ansible-ee-integration-ios-latest FAILURE in 15m 36s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 13m 18s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 15m 46s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 13m 15s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 12m 26s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 06s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 12m 24s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 13m 12s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 10s

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/43ed915ba21842bc9c6b347e5e5945e9

✔️ ansible-galaxy-importer SUCCESS in 5m 08s
✔️ build-ansible-collection SUCCESS in 8m 39s
ansible-ee-integration-ios-latest FAILURE in 14m 14s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 16m 40s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 17m 56s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 18m 06s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 17m 17s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 17s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 14m 52s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 14m 13s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 13s

@softwarefactory-project-zuul
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2029d85130c248a78f2549593e94e03e

✔️ ansible-galaxy-importer SUCCESS in 4m 35s
✔️ build-ansible-collection SUCCESS in 8m 46s
ansible-ee-integration-ios-latest FAILURE in 17m 41s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 12m 31s (non-voting)
ansible-ee-integration-ios-stable-2.11 FAILURE in 14m 03s (non-voting)
ansible-ee-integration-ios-stable-2.12 FAILURE in 14m 36s (non-voting)
ansible-ee-integration-ios-libssh-latest FAILURE in 13m 54s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 14m 30s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 14m 24s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 12m 00s (non-voting)
✔️ ansible-tox-linters SUCCESS in 10m 02s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/969f2f960766412eb593d079f96c7738

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 10m 31s
ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 36s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 17m 39s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 3m 23s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 42s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 4m 26s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 16m 35s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 06s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 4m 35s (non-voting)
✔️ ansible-tox-linters SUCCESS in 12m 14s

@KB-perByte
Copy link
Collaborator

Hey @PadminiSivaraj
the integration tests are passing for ios_vxlan_vtep, but the changes in this PR make the previously merged ios_evpn_evi module's test fail.
Adding the logs from dcloud session below,

TASK [ios_evpn_evi : Assert that before dicts are correctly generated] *********
task path: /home/cisco/test_collections/collections/ansible_collections/cisco/ios/tests/output/.tmp/integration/ios_evpn_evi-bhxhehi1-ÅÑŚÌβŁÈ/tests/integration/targets/ios_evpn_evi/tests/cli/overridden.yaml:31
Loading collection ansible.utils from /home/cisco/test_collections/collections/ansible_collections/ansible/utils
<198.18.1.15> attempting to start connection
<198.18.1.15> using connection plugin ansible.netcommon.network_cli
Found ansible-connection at path /home/cisco/ansible/bin/ansible-connection
<198.18.1.15> found existing local domain socket, using it!
<198.18.1.15> updating play_context for connection
<198.18.1.15> Loading collection ansible.builtin from 
<198.18.1.15> local domain socket path is /home/cisco/.ansible/pc/f6427da97e
ok: [198.18.1.15] => {
    "changed": false,
    "msg": "All assertions passed"
}

TASK [ios_evpn_evi : Assert that after dict is correctly generated] ************
task path: /home/cisco/test_collections/collections/ansible_collections/cisco/ios/tests/output/.tmp/integration/ios_evpn_evi-bhxhehi1-ÅÑŚÌβŁÈ/tests/integration/targets/ios_evpn_evi/tests/cli/overridden.yaml:36
Loading collection ansible.utils from /home/cisco/test_collections/collections/ansible_collections/ansible/utils
<198.18.1.15> attempting to start connection
<198.18.1.15> using connection plugin ansible.netcommon.network_cli
Found ansible-connection at path /home/cisco/ansible/bin/ansible-connection
<198.18.1.15> found existing local domain socket, using it!
<198.18.1.15> updating play_context for connection
<198.18.1.15> Loading collection ansible.builtin from 
<198.18.1.15> local domain socket path is /home/cisco/.ansible/pc/f6427da97e
fatal: [198.18.1.15]: FAILED! => {
    "assertion": "overridden['after'] == result['after']",
    "changed": false,
    "evaluated_to": false,
    "msg": "Assertion failed"
}

TASK [ios_evpn_evi : ansible.builtin.include_tasks] ****************************
task path: /home/cisco/test_collections/collections/ansible_collections/cisco/ios/tests/output/.tmp/integration/ios_evpn_evi-bhxhehi1-ÅÑŚÌβŁÈ/tests/integration/targets/ios_evpn_evi/tests/cli/overridden.yaml:50
redirecting (type: action) cisco.ios.ios_evpn_evi to cisco.ios.ios
included: /home/cisco/test_collections/collections/ansible_collections/cisco/ios/tests/output/.tmp/integration/ios_evpn_evi-bhxhehi1-ÅÑŚÌβŁÈ/tests/integration/targets/ios_evpn_evi/tests/cli/_remove_config.yaml for 198.18.1.15
redirecting (type: action) cisco.ios.ios_evpn_evi to cisco.ios.ios

Just so you know, the whole integration test suite should pass at once, and the tests for the modules individually should pass.
The tests for ios_evpn_evi were passing before we merged it but for some configuration updates that were done via this PR i.e ios_vxlan_vtep it's making the tests for ios_evpn_evi fail.
Could you please take a look.
Regards.

@KB-perByte
Copy link
Collaborator

@PadminiSivaraj there is one minor lint issue that needs to be fixed

Error: requires_ansible key must be set to a supported version.
yaml[empty-lines]: Too many blank lines (1 > 0)
plugins/modules/ios_evpn_evi.py:479

Error: Too many blank lines (1 > 0)
Read documentation for instructions on how to ignore specific rule violations.

                        Rule Violation Summary                        
 count tag                               profile rule associated tags 
     1 yaml[empty-lines]                 basic   formatting, yaml     
     1 meta-runtime[unsupported-version] shared  metadata             

Please note that the yaml[empty-lines] lint issue needs a fix.
meta-runtime[unsupported-version] failure to be ignored for this PR as that action item is on the Ansible Network team, the changes in this PR does not trigger the meta-runtime failure.

Regards,

let us know if you need any help.

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/3419f18e735e4a1788d5e1bde525662c

✔️ ansible-galaxy-importer SUCCESS in 4m 43s
✔️ build-ansible-collection SUCCESS in 10m 40s
ansible-ee-integration-ios-latest RETRY_LIMIT in 6m 09s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 20m 15s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 6m 09s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 6m 44s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 5m 41s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 28s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 5m 36s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 6m 59s (non-voting)
✔️ ansible-tox-linters SUCCESS in 12m 24s

Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/e95658f80677465a9830523d14e5d6c4

✔️ ansible-galaxy-importer SUCCESS in 3m 33s
✔️ build-ansible-collection SUCCESS in 10m 14s
ansible-ee-integration-ios-latest RETRY_LIMIT in 4m 35s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 20m 22s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 4m 33s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 4m 37s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 4m 27s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 15m 25s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 50s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 4m 22s (non-voting)
✔️ ansible-tox-linters SUCCESS in 13m 00s

@KB-perByte KB-perByte removed the feature This issue/PR relates to a feature request. label Nov 16, 2023
@KB-perByte KB-perByte added the feature This issue/PR relates to a feature request. label Nov 16, 2023
Copy link

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/462cd47b2c4e428c849dfa308b84fb4c

✔️ ansible-galaxy-importer SUCCESS in 4m 51s
✔️ build-ansible-collection SUCCESS in 10m 23s
ansible-ee-integration-ios-latest RETRY_LIMIT in 3m 18s (non-voting)
ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 46s (non-voting)
ansible-ee-integration-ios-stable-2.11 RETRY_LIMIT in 6m 13s (non-voting)
ansible-ee-integration-ios-stable-2.12 RETRY_LIMIT in 6m 16s (non-voting)
ansible-ee-integration-ios-libssh-latest RETRY_LIMIT in 3m 24s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 13m 58s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.11 RETRY_LIMIT in 3m 24s (non-voting)
ansible-ee-integration-ios-libssh-stable-2.12 RETRY_LIMIT in 3m 17s (non-voting)
✔️ ansible-tox-linters SUCCESS in 11m 27s

@KB-perByte KB-perByte merged commit 8c6d115 into ansible-collections:main Nov 20, 2023
50 of 51 checks passed
@PadminiSivaraj PadminiSivaraj deleted the add_vxlan_vtep_plugin branch November 20, 2023 08:05
@PadminiSivaraj PadminiSivaraj restored the add_vxlan_vtep_plugin branch December 21, 2023 13:09
@PadminiSivaraj PadminiSivaraj deleted the add_vxlan_vtep_plugin branch December 21, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants