Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vlans context gathered operation #1151

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

rohitthakur2590
Copy link
Contributor

@rohitthakur2590 rohitthakur2590 commented Jan 3, 2025

SUMMARY
  • Fixed an issue with VLAN configuration gathering where pre-filled data was blocking proper fetching of dynamic VLAN details. Now VLAN facts are populated correctly for all cases.
  • Cleaned up unit tests that were passing for the wrong reasons. The updated tests now ensure the right config sections are verified for VLAN configurations.
  • Added a test to validate the gathered state for VLAN configuration context, improving reliability.
  • Made improvements to ensure VLAN facts are gathered properly, both for specific configurations and general VLAN settings.

Resolves

https://issues.redhat.com/browse/ANA-602

@rohitthakur2590 rohitthakur2590 added the vlans vlans resource module label Jan 3, 2025
@github-actions github-actions bot added the safe to test For network-integration jobs label Jan 3, 2025
@roverflow roverflow merged commit a07e958 into ansible-collections:main Jan 16, 2025
63 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test For network-integration jobs vlans vlans resource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants