-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix idempotency issue where ospfv2 module was un idempotent when set interface was set true #1137
Open
Girish5tri
wants to merge
9
commits into
ansible-collections:main
Choose a base branch
from
Girish5tri:fix_idempotency_ospfv2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix idempotency issue where ospfv2 module was un idempotent when set interface was set true #1137
Girish5tri
wants to merge
9
commits into
ansible-collections:main
from
Girish5tri:fix_idempotency_ospfv2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1137 +/- ##
==========================================
+ Coverage 86.90% 87.06% +0.16%
==========================================
Files 193 199 +6
Lines 11904 12083 +179
==========================================
+ Hits 10345 10520 +175
- Misses 1559 1563 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates documentation to clarify non-idempotent behavior of set_interface parameter in cisco.ios.ios_ospfv2 module.
Problem
The module doesn't properly document that set_interface parameter is not idempotent on subsequent runs.
When configuring passive interfaces, the module was reporting changes even when the configuration remained unchanged, it was due to the
set_interface
parameter being not included in state comparison.When running a playbook with set_interface multiple times:
The module shows changed and triggers unnecessary commands because the playbook configuration contains set_interface: true while the running configuration doesn't (since it's only a setup flag). This mismatch causes the module to incorrectly detect a configuration difference, leading to:
FIX
Updated module documentation to clearly indicate set_interface's non-idempotent behavior:
Fixes: #1130
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
cisco.ios.ios_ospfv2