Support for explicit proxy using ansible variable instead of environment variable #556

yodzeb · 2023-06-23T08:29:30Z

SUMMARY

Following issue :
fortinet-ansible-dev/ansible-galaxy-fortios-collection#240

The only way to use a proxy is to set the HTTP(S)_PROXY environment variables which are set globally for the ansible process. Unfortunatelly it does not permit to set a different proxy for different host or host_groups

Adding this option will allow to dynamically set an httpapi ansible variable "ansible_httpapi_explicit_proxy" based on host/hostgroup or any variable.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

httpapi

ADDITIONAL INFORMATION

In the send() fonction, os.environ variable HTTPS_PROXY and HTTP_PROXY are reset with the value provided.

This adds a new dependency with os python library. It may be improved or written differently i guess.

Usage:

- name: xxx
  hosts:
    - xxx
  gather_facts: True
  collections:
    - fortinet.fortios
  vars:
    ansible_httpapi_port: 443
    ansible_httpapi_use_ssl: True
    ansible_httpapi_validate_certs: False
    ansible_httpapi_use_proxy: True
    ansible_network_os: fortinet.fortios.fortios
    ansible_network_import_modules: False
    ansible_httpapi_explicit_proxy: "{{ ps }}"     # <<<<<< 
  connection: httpapi
[...]

Support for an explicit proxy via ansible variable. fortinet-ansible-dev/ansible-galaxy-fortios-collection#240

Support for explicit proxy via ansible variable instead of environment variable

for more information, see https://pre-commit.ci

codecov · 2023-06-23T08:37:44Z

Codecov Report

Merging #556 (2989699) into main (d46298a) will not change coverage.
The diff coverage is n/a.

❗ Current head 2989699 differs from pull request most recent head ccfd02b. Consider uploading reports for the commit ccfd02b to get more accurate results

@@           Coverage Diff           @@
##             main     #556   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files          31       31           
  Lines        3868     3868           
  Branches      685      685           
=======================================
  Hits         2494     2494           
  Misses       1231     1231           
  Partials      143      143

softwarefactory-project-zuul · 2023-06-23T12:48:20Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/2e88d1ee599445588121ae64b394dcb0

softwarefactory-project-zuul · 2023-07-13T14:22:52Z

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4563be4b5860495eaa0b16542f1045e0

yodzeb and others added 3 commits June 23, 2023 10:14

Update httpapi.py

36cdc6b

Support for an explicit proxy via ansible variable. fortinet-ansible-dev/ansible-galaxy-fortios-collection#240

Merge pull request #1 from yodzeb/yodzeb-patch-1

046d201

Support for explicit proxy via ansible variable instead of environment variable

[pre-commit.ci] auto fixes from pre-commit.com hooks

2989699

for more information, see https://pre-commit.ci

yodzeb marked this pull request as draft June 23, 2023 09:51

Create 556-ansible_httpapi_explicit_proxy.yml

6bfd733

yodzeb closed this Jun 23, 2023

yodzeb reopened this Jun 23, 2023

yodzeb marked this pull request as ready for review June 23, 2023 10:00

KB-perByte requested a review from Qalthos June 28, 2023 13:09

Merge branch 'main' into main

ccfd02b

rohitthakur2590 assigned NilashishC Jul 10, 2024

rohitthakur2590 requested review from NilashishC and removed request for Qalthos July 10, 2024 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for explicit proxy using ansible variable instead of environment variable #556

Support for explicit proxy using ansible variable instead of environment variable #556

yodzeb commented Jun 23, 2023

codecov bot commented Jun 23, 2023 •

edited

Loading

softwarefactory-project-zuul bot commented Jun 23, 2023

softwarefactory-project-zuul bot commented Jul 13, 2023

Support for explicit proxy using ansible variable instead of environment variable #556

Are you sure you want to change the base?

Support for explicit proxy using ansible variable instead of environment variable #556

Conversation

yodzeb commented Jun 23, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

codecov bot commented Jun 23, 2023 • edited Loading

Codecov Report

softwarefactory-project-zuul bot commented Jun 23, 2023

softwarefactory-project-zuul bot commented Jul 13, 2023

codecov bot commented Jun 23, 2023 •

edited

Loading