Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new options to httpapi connection #545

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Add new options to httpapi connection #545

merged 1 commit into from
Aug 4, 2023

Conversation

Qalthos
Copy link
Collaborator

@Qalthos Qalthos commented May 19, 2023 •
edited
Loading

SUMMARY

Fixes #528

Adds four new options to the httpapi conenction: ca_path, client_cert, client_key, and http_agent.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

httpapi

@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Merging #545 (9b64b95) into main (f991f0d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   64.47%   64.47%           
=======================================
  Files          31       31           
  Lines        3868     3868           
  Branches      685      685           
=======================================
  Hits         2494     2494           
  Misses       1231     1231           
  Partials      143      143

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6f05385da62b469ca54985702e42bfc0

❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 14m 04s (non-voting)
❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 FAILURE in 1h 26m 49s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 05m 51s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39 SUCCESS in 50m 34s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 13m 22s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 17m 13s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 16m 08s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39 SUCCESS in 16m 58s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 18m 29s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 SUCCESS in 16m 39s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 SUCCESS in 15m 18s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 SUCCESS in 16m 05s
❌ ansible-test-network-integration-nxos-cli-python39-scenario01 FAILURE in 31m 19s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario02 FAILURE in 37m 31s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario03 SUCCESS in 34m 27s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 35m 47s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-python39 SUCCESS in 57m 28s (non-voting)
✔️ ansible-test-network-integration-eos-httpapi-python39 SUCCESS in 45m 45s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-libssh-python39 SUCCESS in 57m 16s (non-voting)
❌ ansible-ee-integration-ios-latest FAILURE in 18m 15s (non-voting)
❌ ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 05s (non-voting)
❌ ansible-ee-integration-ios-stable-2.11 FAILURE in 15m 09s (non-voting)
❌ ansible-ee-integration-ios-stable-2.12 FAILURE in 19m 42s (non-voting)
❌ ansible-ee-integration-ios-libssh-latest FAILURE in 48m 16s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 44m 45s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 48m 21s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 44m 10s (non-voting)
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0005985463 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0005985464 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0005985465 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0005985466 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0005985467 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0005985468 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0005985469 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0005985470 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0005985471 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0005985472 failed in 0s
✔️ build-ansible-collection SUCCESS in 14m 52s
✔️ ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 SUCCESS in 12m 58s
✔️ ansible-tox-linters SUCCESS in 10m 34s
✔️ ansible-galaxy-importer SUCCESS in 3m 52s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/ab8fb55a6dfa439d8b15cb4e2450a4dd

❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 15m 00s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 SUCCESS in 1h 14m 27s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 01m 58s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39 SUCCESS in 51m 58s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 13m 58s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 19m 17s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 19m 26s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39 SUCCESS in 15m 48s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 17m 36s (non-voting)
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 FAILURE in 16m 10s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 SUCCESS in 17m 22s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 SUCCESS in 18m 18s
✔️ ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 29m 12s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario02 FAILURE in 36m 40s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario03 SUCCESS in 32m 46s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 32m 36s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-python39 SUCCESS in 52m 09s (non-voting)
✔️ ansible-test-network-integration-eos-httpapi-python39 SUCCESS in 42m 10s (non-voting)
✔️ ansible-test-network-integration-eos-network_cli-libssh-python39 SUCCESS in 53m 34s (non-voting)
❌ ansible-ee-integration-ios-latest FAILURE in 15m 23s (non-voting)
❌ ansible-ee-integration-ios-stable-2.9 FAILURE in 15m 04s (non-voting)
❌ ansible-ee-integration-ios-stable-2.11 FAILURE in 14m 08s (non-voting)
❌ ansible-ee-integration-ios-stable-2.12 FAILURE in 17m 05s (non-voting)
❌ ansible-ee-integration-ios-libssh-latest FAILURE in 45m 22s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 37m 52s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 41m 47s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 41m 56s (non-voting)
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0006135477 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0006135478 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0006135479 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0006135480 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0006135481 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0006135482 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0006135483 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0006135484 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0006135485 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0006135486 failed in 0s
✔️ build-ansible-collection SUCCESS in 14m 11s
✔️ ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 SUCCESS in 12m 52s
✔️ ansible-tox-linters SUCCESS in 10m 24s
✔️ ansible-galaxy-importer SUCCESS in 3m 59s

@Qalthos Qalthos added the feature This issue/PR relates to a feature request. label Jun 21, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/1294ffceaf9a491cbaed97099a50bbbc

❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable29 FAILURE in 14m 44s (non-voting)
❌ ansible-test-network-integration-junos-vsrx-netconf-python36-stable211 NODE_FAILURE Node request 200-0006254462 failed in 0s
✔️ ansible-test-network-integration-junos-vsrx-netconf-python39-stable212 SUCCESS in 1h 08m 00s
❌ ansible-test-network-integration-junos-vsrx-netconf-python39 RETRY_LIMIT in 47s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable29 FAILURE in 14m 06s (non-voting)
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python36-stable211 SUCCESS in 18m 44s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-python39-stable212 SUCCESS in 17m 05s
❌ ansible-test-network-integration-junos-vsrx-network_cli-python39 RETRY_LIMIT in 9m 47s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable29 FAILURE in 17m 28s (non-voting)
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python36-stable211 FAILURE in 15m 16s
✔️ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39-stable212 SUCCESS in 16m 50s
❌ ansible-test-network-integration-junos-vsrx-network_cli-libssh-python39 RETRY_LIMIT in 8m 42s
✔️ ansible-test-network-integration-nxos-cli-python39-scenario01 SUCCESS in 30m 43s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario02 SUCCESS in 29m 06s (non-voting)
❌ ansible-test-network-integration-nxos-cli-python39-scenario03 FAILURE in 36m 57s (non-voting)
✔️ ansible-test-network-integration-nxos-cli-python39-scenario04 SUCCESS in 29m 26s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-python39 RETRY_LIMIT in 5m 15s (non-voting)
❌ ansible-test-network-integration-eos-httpapi-python39 RETRY_LIMIT in 5m 53s (non-voting)
❌ ansible-test-network-integration-eos-network_cli-libssh-python39 RETRY_LIMIT in 5m 17s (non-voting)
❌ ansible-ee-integration-ios-latest FAILURE in 14m 16s (non-voting)
❌ ansible-ee-integration-ios-stable-2.9 FAILURE in 12m 45s (non-voting)
❌ ansible-ee-integration-ios-stable-2.11 FAILURE in 12m 47s (non-voting)
❌ ansible-ee-integration-ios-stable-2.12 FAILURE in 14m 14s (non-voting)
❌ ansible-ee-integration-ios-libssh-latest FAILURE in 12m 39s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.9 FAILURE in 12m 46s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.11 FAILURE in 15m 29s (non-voting)
❌ ansible-ee-integration-ios-libssh-stable-2.12 FAILURE in 15m 44s (non-voting)
❌ ansible-test-network-integration-vyos-paramiko-python39-devel NODE_FAILURE Node request 200-0006254488 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable214 NODE_FAILURE Node request 200-0006254489 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable213 NODE_FAILURE Node request 200-0006254490 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python39-stable212 NODE_FAILURE Node request 200-0006254491 failed in 0s
❌ ansible-test-network-integration-vyos-paramiko-python36-stable29 NODE_FAILURE Node request 200-0006254492 failed in 0s (non-voting)
❌ ansible-test-network-integration-vyos-libssh-python39-devel NODE_FAILURE Node request 200-0006254493 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable214 NODE_FAILURE Node request 200-0006254494 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable213 NODE_FAILURE Node request 200-0006254495 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python39-stable212 NODE_FAILURE Node request 200-0006254496 failed in 0s
❌ ansible-test-network-integration-vyos-libssh-python36-stable29 NODE_FAILURE Node request 200-0006254497 failed in 0s
✔️ build-ansible-collection SUCCESS in 14m 35s
❌ ansible-test-network-integration-ansible-netcommon-junos-vsrx-netconf-python39 RETRY_LIMIT in 8m 38s
✔️ ansible-tox-linters SUCCESS in 10m 45s
✔️ ansible-galaxy-importer SUCCESS in 4m 35s

@Qalthos Qalthos merged commit 46dcfcd into ansible-collections:main Aug 4, 2023
49 of 50 checks passed
@Qalthos Qalthos deleted the httpapi_options branch August 4, 2023 18:28
@hellt hellt mentioned this pull request Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitthakur2590 rohitthakur2590 Awaiting requested review from rohitthakur2590

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support setting custom CA bundle for httpapi connection plugin
1 participant
@Qalthos