[WIP] Make restconf_get work with NX-OS #307
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NilashishC <[email protected]>
Qalthos
requested changes
Sep 23, 2021
| @@ -73,9 +73,10 @@ def send_request(self, data, **message_kwargs): | |||
|
|
|||
| def handle_response(response, response_data): | |||
| try: | |||
| response_data = json.loads(response_data.read()) | |||
| res = response_data.read().strip() | |||
There was a problem hiding this comment.
Suggested change
| res = response_data.read().strip() | |
| res = response_data.read().strip() | |
| try: |
(It won't let me remove the try above, but you get the idea)
The reason it's split into response and response_data is that the latter is a buffer containing the read-once data from the former, so you should be able to response_data.seek(0) and get the same result. But this is just fine, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: NilashishC [email protected]
SUMMARY
Fixes #306
ISSUE TYPE
COMPONENT NAME
restconf_get.py