Revert edit_config signature updates in #653 (#640)

* Revert edit_config signature updates in #653 Signed-off-by: NilashishC <[email protected]> * Add changelog Signed-off-by: NilashishC <[email protected]> * Revert RMBase changes Signed-off-by: NilashishC <[email protected]> --------- Signed-off-by: NilashishC <[email protected]>
ansible-collections · May 27, 2024 · d28c8fc · d28c8fc
1 parent 569f662
commit d28c8fc
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/changelogs/fragments/bug_653.yaml b/changelogs/fragments/bug_653.yaml
@@ -0,0 +1,3 @@
+---
+bugfixes:
+  - The v6.1.2 release introduced a change in cliconfbase's edit_config() signature which broke many platform cliconfs. This patch would revert that change.
diff --git a/plugins/module_utils/network/common/rm_base/resource_module.py b/plugins/module_utils/network/common/rm_base/resource_module.py
@@ -145,9 +145,9 @@ def compare(self, parsers, want=None, have=None):
                 else:
                     self.addcmd(have, parser, True)
 
-    def run_commands(self, err_responses=None):
+    def run_commands(self):
         """Send commands to the device"""
         if self.commands and self.state in self.ACTION_STATES:
             if not self._module.check_mode:
-                self._connection.edit_config(candidate=self.commands, err_responses=err_responses)
+                self._connection.edit_config(candidate=self.commands)
             self.changed = True
diff --git a/plugins/plugin_utils/cliconf_base.py b/plugins/plugin_utils/cliconf_base.py
@@ -215,7 +215,6 @@ def edit_config(
         replace=None,
         diff=False,
         comment=None,
-        err_responses=None,
     ):
         """Loads the candidate configuration into the network device
 
@@ -235,8 +234,6 @@ def edit_config(
                         the file in this case should be present on the remote host in the mentioned path as a
                         prerequisite.
         :param comment: Commit comment provided it is supported by remote host.
-        :param err_responses: A list of error regexes that will be used to evaluate the responses received
-                              from executing the candidate command(s).
         :return: Returns a json string with contains configuration applied on remote host, the returned
                  response on executing configuration commands and platform relevant data.
                {