Big IAM code refactor #1998
Big IAM code refactor #1998
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 45s |
tremble
force-pushed
the
iam-refactor
branch
from
f17fcfe
to
45578a1
Compare
tremble
force-pushed
the
iam-refactor
branch
from
45578a1
to
a8798ab
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 10s |
Yeah integration tests now pass (iam_access_key didn't run due to bad indentation on no_log) |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 25s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 5m 30s |
softwarefactory-project-zuul
bot
merged commit d3edef2
into
ansible-collections:main
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #2005 🤖 @patchback |
Big IAM code refactor SUMMARY Refactored code to use AnsibleIAMError and IAMErrorHandler as well as moving shared code into module_utils.iam iam_role_info - Deprecate support for paths without leading and trailing \ ISSUE TYPE Feature Pull Request COMPONENT NAME iam_access_key iam_access_key_info iam_group iam_instance_profile iam_instance_profile_info iam_managed_policy iam_mfa_device_info iam_role iam_role_info iam_user iam_user_info ADDITIONAL INFORMATION Reviewed-by: Helen Bailey <[email protected]> Reviewed-by: GomathiselviS Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis (cherry picked from commit d3edef2)
[PR #1998/d3edef23 backport][stable-7] Big IAM code refactor This is a backport of PR #1998 as merged into main (d3edef2). SUMMARY Refactored code to use AnsibleIAMError and IAMErrorHandler as well as moving shared code into module_utils.iam iam_role_info - Deprecate support for paths without leading and trailing \ ISSUE TYPE Feature Pull Request COMPONENT NAME iam_access_key iam_access_key_info iam_group iam_instance_profile iam_instance_profile_info iam_managed_policy iam_mfa_device_info iam_role iam_role_info iam_user iam_user_info ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…mValidationError during policy deletion (#2068) iam_managed_policy - fix ParamValidationError during policy deletion SUMMARY fixes: #2067 Introduced by #1998 A copy and paste mistake in #1998 resulted in ParamValidationErrors being triggered when deleting a managed policy which is still attached to a role or user. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_managed_policy plugins/module_utils/iam.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
…mValidationError during policy deletion (#2068) iam_managed_policy - fix ParamValidationError during policy deletion SUMMARY fixes: #2067 Introduced by #1998 A copy and paste mistake in #1998 resulted in ParamValidationErrors being triggered when deleting a managed policy which is still attached to a role or user. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_managed_policy plugins/module_utils/iam.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis (cherry picked from commit 970c303)
…mValidationError during policy deletion (#2068) (#2071) [PR #2068/970c3032 backport][stable-7] iam_managed_policy - fix ParamValidationError during policy deletion This is a backport of PR #2068 as merged into main (970c303). SUMMARY fixes: #2067 Introduced by #1998 A copy and paste mistake in #1998 resulted in ParamValidationErrors being triggered when deleting a managed policy which is still attached to a role or user. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_managed_policy plugins/module_utils/iam.py ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
…mValidationError during policy deletion (ansible-collections#2068) iam_managed_policy - fix ParamValidationError during policy deletion SUMMARY fixes: ansible-collections#2067 Introduced by ansible-collections#1998 A copy and paste mistake in ansible-collections#1998 resulted in ParamValidationErrors being triggered when deleting a managed policy which is still attached to a role or user. ISSUE TYPE Bugfix Pull Request COMPONENT NAME iam_managed_policy plugins/module_utils/iam.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis
SUMMARY
Refactored code to use
AnsibleIAMErrorandIAMErrorHandleras well as moving shared code into module_utils.iamiam_role_info - Deprecate support for paths without leading and trailing
\ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION