Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various airflow provider improvements #4

Merged
merged 6 commits into from
Dec 13, 2023
Merged

Various airflow provider improvements #4

merged 6 commits into from
Dec 13, 2023

Conversation

mtagle
Copy link
Contributor

@mtagle mtagle commented Dec 11, 2023

Various airflow provider improvements:

  • allow the airflow provider to work with python 3.8
  • change existing operators (AnomaloPassFailOperator, AnomaloRunCheckOperator to optionally take a date for checks to be run for, rather than always running them for the most recent date.
  • change AnomaloRunCheckOperator to optionally take in a list of check ids to run, instead of always running all configured checks.
  • Add AnomaloCheckRunResultOperator which will pass or fail based on a passed in function that can check a result run. This can be used to gate downstream tasks based on anything that is contained within a previous run result.
  • Refactor AnomaloRunCheckOperator to be based on the new, more generic AnomaloCheckRunResultOperator

Why?

Customers have asked for this functionality.

Review Notes

@@ -37,7 +37,7 @@

anomalo_validate = AnomaloPassFailOperator(
task_id="AnomaloPassFail",
table_name="public-bq.crypto_bitcoin.outputs",
table_name="public-bq.austin_bikeshare.bikeshare_stations",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for testing; this runs significantly faster (nigh-instananeously) instead of crypto_bitcoin.outputs, which takes > 15 mins

@mtagle mtagle changed the title Bringing in some suggested changes Various airflow provider improvements Dec 12, 2023
@mtagle mtagle marked this pull request as ready for review December 12, 2023 00:43
Copy link

@j-bennet j-bennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about airflow operators, but the changes look reasonable.

@mtagle mtagle merged commit c13bde5 into main Dec 13, 2023
1 check passed
@mtagle mtagle deleted the moira-dp-411 branch December 13, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants