This repository has been archived by the owner on Apr 2, 2023. It is now read-only.
Fixes a glitch of opening editor at first click #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you draw more than three polygons, the editor was opening in the first click of the third polygon. It was happening because Annotorious is sending two clicks in the second polygon, three clicks in the third, and so on. The isClosed function checks if it's at least the third point and if it's 5 pixels close to the _anchor point, so it was causing the window to open wrongly. My contribution is a workaround to check if the click is the same as the last one, so it doesn't call the isClosed function if so. It doesn't correct the multiple-click event issue (I think it's a core Annotorious glitch), but it corrects the expected behavior.
|
Hi Rafael, ah - thanks for spotting this! I need to take closer look myself, but it seems it could be because the selector registers mouse listeners on the canvas when it's activated: https://github.com/annotorious/annotorious-selector-pack/blob/master/src/polygon_selector.js#L197 and then when it's deactivated, it doesn't de-register them (it only deletes the reference): If that's indeed the root cause - sorry for this! (Happened when I pulled the polygon selector out of the core code, migrating from Google's Closure Tools utility to JS code without the Closure dependency. The commented lines are still there - yikes!) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user draws more than three polygons, the editor was opening in the first click of the third polygon.
It was happening because Annotorious is sending two clicks in the second polygon, three clicks in the third, and so on. The isClosed function checks if it's at least the third point and if it's 5 pixels close to the _anchor point, so it was causing the window to open wrongly.
My contribution is a workaround to check if the click is the same as the last one, so it doesn't call the isClosed function if so.
It doesn't correct the multiple-click event issue (I think it's a core Annotorious glitch), but it fixes the expected behavior.