Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a locking mechanism to islands #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cyclonit
Copy link
Collaborator

This PR adds a toggle to lock islands. Locked islands can neither be moved nor have any of their properties changed. This prevents moving islands by accident.

Secondly it serves as a foundation for supporting custom Arctic and Enbesa. Due to the presence of custom triggers and other GameObjects, changing certain islands would break quests in those regions. Locking them does not solve all issues but it is a first step in the right direction.

In the future warning messages should be added if the user attempts to unlock an island containing GameObjects.

image

@Cyclonit Cyclonit changed the title Added a locking mechanism to islands Add a locking mechanism to islands May 18, 2023
@Shad0wlife
Copy link
Collaborator

Yeah, this fixes quest triggers that are on the world map but "belong" to an island. BUT we have to make sure that those coordinates don't break when making the map bigger. We might also want to introduce a minimum session size.

@Cyclonit
Copy link
Collaborator Author

Yes, all position updates must either be prevented or be propagated to all relevant objects. I'll look into that later.

@Shad0wlife
Copy link
Collaborator

Good idea. Though it might be difficult to identify the relevant objects. Because simple locations might be fine but paths etc get harder. And island rotation would make extra difficult 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants