Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

batch, vector stores, and fine tuning LRO and subclient pattern updates #11

Merged
merged 22 commits into from
Sep 20, 2024
Merged

batch, vector stores, and fine tuning LRO and subclient pattern updates #11

merged 22 commits into from
Sep 20, 2024

Conversation

chschrae
Copy link

@chschrae chschrae commented Sep 6, 2024

No description provided.

annelo-msft
annelo-msft reviewed Sep 10, 2024
View reviewed changes
Copy link
Owner

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there tests for the Azure LRO types?

chschrae added 6 commits September 11, 2024 11:18
Merge remote-tracking branch 'remotes/anne/oai-polling-lro' into oai-…
041b6ff 
…polling-lro

# Conflicts:
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/Batch/AzureBatchClient.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/Batch/AzureCreateBatchOperation.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/FineTuning/AzureCreateJobOperation.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/FineTuning/AzureFineTuningClient.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureAddFileToVectorStoreOperation.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureAddFileToVectorStoreOperation.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureCreateBatchFileJobOperation.Protocol.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureCreateBatchFileJobOperation.cs
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureCreateVectorStoreOperation.cs
#	.dotnet/src/Custom/Batch/BatchClient.cs
#	.dotnet/src/Custom/FineTuning/FineTuningClient.cs
#	.dotnet/src/Custom/VectorStores/VectorStoreClient.cs
#	.dotnet/src/Generated/FineTuningClient.cs
fixing some merge build errors
1e93130
updated batch and vector store tests
b937a54
updated tests and fixed CreateJob functions to call internal factory
cea2130
PR nits and moved message builder methods to .Protocol files
46341dc
fixing openAI file client in tests
e3a4a40
annelo-msft
annelo-msft approved these changes Sep 19, 2024
View reviewed changes
Copy link
Owner

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge with a plan for a follow up PR to address ContinuationToken issues

@annelo-msft annelo-msft merged commit 317601a into annelo-msft:oai-polling-lro Sep 20, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trrwilson trrwilson trrwilson left review comments

@annelo-msft annelo-msft annelo-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chschrae @annelo-msft @trrwilson