forked from bterlson/openai-in-typespec
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch, vector stores, and fine tuning LRO and subclient pattern updates #11
Merged
annelo-msft
merged 22 commits into
annelo-msft:oai-polling-lro
from
chschrae:oai-polling-lro
Sep 20, 2024
Merged
batch, vector stores, and fine tuning LRO and subclient pattern updates #11
annelo-msft
merged 22 commits into
annelo-msft:oai-polling-lro
from
chschrae:oai-polling-lro
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
reviewed
Sep 10, 2024
annelo-msft
reviewed
Sep 10, 2024
annelo-msft
reviewed
Sep 10, 2024
annelo-msft
reviewed
Sep 10, 2024
annelo-msft
reviewed
Sep 10, 2024
.dotnet/src/Custom/VectorStores/CreateVectorStoreOperation.Protocol.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 10, 2024
annelo-msft
reviewed
Sep 10, 2024
annelo-msft
reviewed
Sep 10, 2024
annelo-msft
reviewed
Sep 10, 2024
.dotnet.azure/src/Custom/VectorStores/AzureCreateVectorStoreOperation.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 10, 2024
.dotnet.azure/src/Custom/FineTuning/AzureCreateJobOperation.Protocol.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 10, 2024
.dotnet.azure/src/Custom/FineTuning/AzureCreateJobOperation.Protocol.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there tests for the Azure LRO types?
trrwilson
reviewed
Sep 11, 2024
…polling-lro # Conflicts: # .dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/Batch/AzureBatchClient.Protocol.cs # .dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/Batch/AzureCreateBatchOperation.Protocol.cs # .dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/FineTuning/AzureCreateJobOperation.Protocol.cs # .dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/FineTuning/AzureFineTuningClient.Protocol.cs # .dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureAddFileToVectorStoreOperation.Protocol.cs # .dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureAddFileToVectorStoreOperation.cs # .dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureCreateBatchFileJobOperation.Protocol.cs # .dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureCreateBatchFileJobOperation.cs # .dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureCreateVectorStoreOperation.cs # .dotnet/src/Custom/Batch/BatchClient.cs # .dotnet/src/Custom/FineTuning/FineTuningClient.cs # .dotnet/src/Custom/VectorStores/VectorStoreClient.cs # .dotnet/src/Generated/FineTuningClient.cs
annelo-msft
reviewed
Sep 17, 2024
annelo-msft
reviewed
Sep 17, 2024
...t.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/FineTuning/AzureCreateJobOperation.Protocol.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
...t.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/FineTuning/AzureCreateJobOperation.Protocol.cs
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
...penai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureAddFileToVectorStoreOperation.Protocol.cs
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
.dotnet.azure/sdk/openai/Azure.AI.OpenAI/src/Custom/Batch/AzureCreateBatchOperation.Protocol.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
annelo-msft
reviewed
Sep 17, 2024
.dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
annelo-msft
reviewed
Sep 17, 2024
annelo-msft
reviewed
Sep 17, 2024
annelo-msft
reviewed
Sep 17, 2024
.dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
.dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
.dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
.dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
annelo-msft
reviewed
Sep 17, 2024
annelo-msft
reviewed
Sep 17, 2024
.dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/VectorStoreTests.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
.dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/VectorStoreTests.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
.dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/VectorStoreTests.cs
Outdated
Show resolved
Hide resolved
annelo-msft
reviewed
Sep 17, 2024
.dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/VectorStoreTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Anne Thompson <[email protected]>
…s.cs Co-authored-by: Anne Thompson <[email protected]>
…e-openai-in-typespec into oai-polling-lro # Conflicts: # .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
annelo-msft
reviewed
Sep 18, 2024
....azure/sdk/openai/Azure.AI.OpenAI/src/Custom/VectorStores/AzureVectorStoreClient.Protocol.cs
Show resolved
Hide resolved
annelo-msft
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge with a plan for a follow up PR to address ContinuationToken issues
annelo-msft
merged commit Sep 20, 2024
317601a
into
annelo-msft:oai-polling-lro
1 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.