Skip to content

Commit

Permalink
Merge branch 'oai-polling-lro' of https://github.com/chschrae/chschra…
Browse files Browse the repository at this point in the history
…e-openai-in-typespec into oai-polling-lro

# Conflicts:
#	.dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs
  • Loading branch information
chschrae committed Sep 18, 2024
2 parents 7373eb8 + d8d82ef commit fd086f0
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ public async Task CreateAndDeleteFineTuning()
TrainingFile = uploadedFile.Id
}.ToBinaryContent();

CreateJobOperation operation = await client.CreateJobAsync(requestContent, false);
CreateJobOperation operation = await client.CreateJobAsync(requestContent, waitForCompletion: false);

Check failure on line 212 in .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs

View workflow job for this annotation

GitHub Actions / azure_build (ubuntu-latest, net8.0)

The best overload for 'CreateJobAsync' does not have a parameter named 'waitForCompletion'

Check failure on line 212 in .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs

View workflow job for this annotation

GitHub Actions / azure_build (ubuntu-latest, net8.0)

The best overload for 'CreateJobAsync' does not have a parameter named 'waitForCompletion'

Check failure on line 212 in .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs

View workflow job for this annotation

GitHub Actions / azure_build (ubuntu-latest, net8.0)

The best overload for 'CreateJobAsync' does not have a parameter named 'waitForCompletion'

Check failure on line 212 in .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs

View workflow job for this annotation

GitHub Actions / azure_build (ubuntu-latest, net8.0)

The best overload for 'CreateJobAsync' does not have a parameter named 'waitForCompletion'

Check failure on line 212 in .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs

View workflow job for this annotation

GitHub Actions / azure_build (macos-latest, net6.0)

The best overload for 'CreateJobAsync' does not have a parameter named 'waitForCompletion'

Check failure on line 212 in .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs

View workflow job for this annotation

GitHub Actions / azure_build (macos-latest, net6.0)

The best overload for 'CreateJobAsync' does not have a parameter named 'waitForCompletion'

Check failure on line 212 in .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs

View workflow job for this annotation

GitHub Actions / azure_build (macos-latest, net6.0)

The best overload for 'CreateJobAsync' does not have a parameter named 'waitForCompletion'

Check failure on line 212 in .dotnet.azure/sdk/openai/Azure.AI.OpenAI/tests/FineTuningTests.cs

View workflow job for this annotation

GitHub Actions / azure_build (macos-latest, net6.0)

The best overload for 'CreateJobAsync' does not have a parameter named 'waitForCompletion'
FineTuningJob job = ValidateAndParse<FineTuningJob>(ClientResult.FromResponse(operation.GetRawResponse()));
Assert.That(job.ID, Is.Not.Null.Or.Empty);
Assert.That(job.Error, Is.Null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public async Task CanCreateGetAndDeleteVectorStores()
{
VectorStoreClient client = GetTestClient();

CreateVectorStoreOperation createVectorStoreOperation = await client.CreateVectorStoreAsync(false);
CreateVectorStoreOperation createVectorStoreOperation = await client.CreateVectorStoreAsync(waitUntilCompleted: false);
Validate(createVectorStoreOperation);
bool deleted = await client.DeleteVectorStoreAsync(createVectorStoreOperation.GetVectorStore());
Assert.That(deleted, Is.True);
Expand Down

0 comments on commit fd086f0

Please sign in to comment.