Int enum support #161
Int enum support #161
Conversation
| if issubclass(enum_type, str): | ||
| return str | ||
| if issubclass(enum_type, int): | ||
| return int |
There was a problem hiding this comment.
It would've been nicer to extract the type instead of doing ad-hoc checks but according to the implementation of StrEnum/IntEnum there's not easy way to do it, right? 😅
There was a problem hiding this comment.
hmm, enum with strings and integers can be declared without using StrEnum/IntEnum and there is an example in tests.
I used the same approach that was before my changes but extended it to support int in addition to str.
I also checked native enum support which was added in marshmallow 3.18, I had thoughts to use it or reuse implementation for v2 but than decided not to change approach used in marshmallow-recipe
There was a problem hiding this comment.
enum with strings and integers can be declared without using StrEnum/IntEnum and there is an example in tests.
Exactly, it's just a mix of Enum and int/str, my idea was to get superclasses of resulting enum, filter out enum-related classes and what's left should be a single alien class which is int or str in this case but could also be anything else
There was a problem hiding this comment.
what are the benefits of suggested approach?
No description provided.