Almost stop using marshmallow defaults (except Nones) #143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to fix of a typo in tests, it has been found that complex default values don't work for marshmallow2 (it tries to parse a default value via field), but do work for marshmallow3:
test_nested_default
demonstrates the issue for a dataclass field default.So, as a solution of the issue, I propose to stop settings default values to marshmallow (except Nones for Optional fields, because our schema removes Nones by default).
Known side effects: