Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus metrics #271

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Prometheus metrics #271

merged 9 commits into from
Oct 21, 2024

Conversation

Pliner
Copy link
Contributor

@Pliner Pliner commented Oct 19, 2024 •
edited
Loading

Prometheus metrics are still implemented inside the library for the backward compatibility with existing usage profile.

Also, there is no need for the following dedicated counters aio_request_status and aio_request_server_status, because aio_request_latency and aio_request_server_latency can easily cover the same usecases.

@Pliner Pliner requested a review from a team as a code owner October 19, 2024 07:27
@Pliner Pliner changed the title Return prometheus metrics w/o any facades Implement prometheus metrics w/o any facades Oct 19, 2024
@Pliner Pliner changed the title Implement prometheus metrics w/o any facades Prometheus metrics Oct 19, 2024
@Pliner Pliner merged commit 5cd83b0 into main Oct 21, 2024
3 checks passed
@Pliner Pliner deleted the prometheus-metrics branch October 21, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-anna-money roman-anna-money roman-anna-money approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pliner @roman-anna-money