Feat: implement wakapi compatibility #256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseusys
reviewed
Jan 14, 2023
| @@ -29,6 +29,7 @@ | |||
| listReg = f"{START_COMMENT}[\\s\\S]+{END_COMMENT}" | |||
|
|
|||
| waka_key = os.getenv('INPUT_WAKATIME_API_KEY') | |||
| waka_url = os.getenv('INPUT_WAKATIME_URL', "https://wakatime.com") | |||
There was a problem hiding this comment.
As far as you can see, for now the environmental variables defaults are defined in action.yml. I understand your will to add defaults here (I hope to do it one day as well), but for now I guess it would be much cooler to put it into action.yml.
| @@ -239,6 +239,8 @@ CSS 2 repos █░░░░░░░░░░░░░░░░ | |||
|
|
|||
| `IGNORED_REPOS` flag can be set to `"waka-readme-stats, my-first-repo"` (just an example) to ignore some repos you don’t want to be counted | |||
|
|
|||
| `WAKATIME_API_URL` flag can be set if you are hosting your own wakatime compliant backend like [wakapi](https://github.com/muety/wakapi). You only have to supply your base url like so `https://wakapi.dev` | |||
There was a problem hiding this comment.
Maybe we should shouw that this is an example link, changing it to something like https://your-own-wakapi.dev? Don't you think so?
| @@ -98,7 +99,6 @@ | |||
| get_profile_traffic = Template("""/repos/$owner/$repo/traffic/popular/referrers""") | |||
| truthy = ['true', '1', 't', 'y', 'yes'] | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
I don't think this change is vital. Also it breaks pep.
|
Closing the PR as it appears to be stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #220