Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyglot_JS Assignment #19

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Clover-Codes
Copy link

@Clover-Codes Clover-Codes commented Feb 12, 2022

Polyglot JS Task Submission

  • Checkpoint 1: Compare the cards of hacker and player.

20pts

  • Checkpoint 2: Keep a track of the individual scores of the hacker and player.

20pts

  • Checkpoint 3: Deploy the code to GitHub Pages.

10pts

  • Extras: You can improve UI of the game ;).

Submission

Repo https://github.com/Clover-Codes/Polyglot_JS
Deployed Site https://clover-codes.github.io/Polyglot_JS/

@shubhangi013
Copy link
Collaborator

@Clover-Codes Please edit this pull request to include the deployed site and the repository

@Clover-Codes
Copy link
Author

@Clover-Codes Please edit this pull request to include the deployed site and the repository

I've edited the comment to add them both. Is it alright now?

@shubhangi013
Copy link
Collaborator

Amazing work 🎉
Few things however:

  • you shouldn't reveal the power of all the cards once the user chooses one of them. Clever users can exploit this to win :p
  • Add a few more scenarios if possible
  • work with the CSS a bit and correct the alignment of the winning and losing messages

@Clover-Codes
Copy link
Author

I'll get to work on these right away, thank you!

@shubhangi013
Copy link
Collaborator

LGTM! 🎊

@Divyansh013 Divyansh013 added the passed Great work label Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
passed Great work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants