ts/src/app.html: Changed from favicon.png to favicon.ico #3485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Fabrizio Orsi <[email protected]>
lima-limon-inc
force-pushed
the
favicon.ico
branch
from
66b80a3
to
6c99490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting the following error when running anki:
Looking through anki's file, I wasn't able to find a
favicon.png. IIANM, here's the only mention of "favicon.png" (I doubled checked with grep).However, I did find a
favicon.icofile.Therefore, I changed the ".png" to ".ico" and anki stopped showing that error.
However, I still wasn't able to see the image. I am not sure where it should be displayed. Plus (and probably the reason why I'm not seeing it), I'm using the qtile window manager, which shows little to no desktop-app-images.
If the ".ico" file extension is needed, I could force push a commit where I add the
favicon.icofile (using ImageMagick).If that is preferred, let me know.
PS: Thank you very much Anki devs for the wonderful app! I used Anki a whiiiiiile ago. I'm glad it's still getting love 😊