-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
load balancer! #3230
Merged
Merged
load balancer! #3230
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
b1836ed
start of load balancer
jakeprobst 5bb8959
add configuration options; option to load balance per deck
jakeprobst ac12e13
formatting
jakeprobst 9c96fe5
clippy
jakeprobst 25a8549
add myself to contributors
jakeprobst cd5e0df
cleanup
jakeprobst 9595f6c
cargo fmt
jakeprobst 63fa18b
copyright header on load_balancer.rs
jakeprobst a2bad0a
remove extra space
jakeprobst d53e248
more formatting
jakeprobst be92048
python formatting
jakeprobst 8e28b71
ignore this being None
jakeprobst 370eef6
only calculate notes on each day if we are trying to avoid siblings
jakeprobst cc3e991
don't fuzz intervals if the load balancer is enabled
jakeprobst 98b3e79
force generator to eval so this actually happens
jakeprobst 4972ef0
load balance instead of fuzzing, rather than in addition to
jakeprobst 672021d
use builtin fuzz_bounds rather than reinvent something new
jakeprobst 901bec7
print some debug info on how its load balancing
jakeprobst d16d4e3
clippy
jakeprobst e3a2d85
more accurately load balance only when we want to fuzz
jakeprobst 7ff398a
incorrectly doublechecking the presence of the load balancer
jakeprobst 47feb8e
more printfs for debugging
jakeprobst e80f90d
avoid siblings -> disperse siblings
jakeprobst ec6e9c0
load balance learning graduating intervals
jakeprobst a539954
load balancer: respect min/max intervals; graduating easy should be a…
jakeprobst b02cf01
filter out after-days under minimum interval
jakeprobst 31691ed
this is an inclusive check
jakeprobst 54521fb
switch load balancer to caching instead of on the fly calculation
jakeprobst 267e255
Merge branch 'main' into load_balancer
jakeprobst 7a6b42c
handle case where load balancer would balance outside of its bounds
jakeprobst 8b93c39
disable lb when unselecting it in preferences
jakeprobst f3fd530
call load_balancer in StateContext::with_review_fuzz instead of next to
jakeprobst daeb154
rebuild load balancer when card queue is rebuilt
jakeprobst f9a0073
remove now-unused configuration options
jakeprobst 17569e7
add note option to notetype to enable/disable sibling dispersion
jakeprobst d52afcd
add options to exclude decks from load balancing
jakeprobst de017e1
theres a lint checking that the link actually exists so I guess I'll …
jakeprobst 033d757
Merge branch 'main' into load_balancer
jakeprobst 4081f22
how did I even update this
jakeprobst 291d8d1
move load balancer to cardqueue
jakeprobst 7441395
remove per-deck balancing options
jakeprobst 3395349
improve determining whether to disperse siblings when load balancing
jakeprobst 580ea5e
don't recalculate notes on days every time
jakeprobst 4ae66ae
Merge branch 'main' into load_balancer
dae ed97e8d
remove debug code
jakeprobst aff9087
remove all configuration; load balancer enabled by default; disperse …
jakeprobst 6b8d9f8
didn't fully remove caring about decks from load balancer sql query
jakeprobst 50e99fe
load balancer should only count cards in the same preset
jakeprobst 0281aff
fuzz interval if its outside of load balancer's range
jakeprobst 6a2b5b9
also check minimum when bailing out of load balancer
jakeprobst b7d0e59
cleanup; make tests happy
jakeprobst a3104ba
experimental weight-based load balance fuzzing
jakeprobst b4207e2
take into account interval when weighting as it seems to help
jakeprobst bcd56a1
if theres no cards the interval weight is just 1.0
jakeprobst 72f9b69
make load balancer disableable through debug console
jakeprobst 73f38d4
remove debug prints
jakeprobst bcfcfc9
typo
jakeprobst 1d8882a
remove debugging print
jakeprobst f98210f
explain a bit how load balancer works
jakeprobst ad6d242
properly balance per preset
jakeprobst af45ea3
use inclusive range rather than +1
jakeprobst 9e13e10
Merge remote-tracking branch 'upstream/main' into load_balancer
jakeprobst 2742d75
-1 type cast
jakeprobst 32840e1
move type hint somewhere less ugly; fix comment typo
jakeprobst edbe52c
Reuse existing deck list from parent function
dae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -181,6 +181,7 @@ James Elmore <[email protected]> | |
Ian Samir Yep Manzano <https://github.com/isym444> | ||
David Culley <[email protected]> | ||
Rastislav Kish <[email protected]> | ||
jake <[email protected]> | ||
Expertium <https://github.com/Expertium> | ||
Christian Donat <https://github.com/cdonat2> | ||
Asuka Minato <https://asukaminato.eu.org> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this change, I get these two type errors from
mypy
:Do you get them too @jakeprobst? Or is this a misconfiguration on my personal system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
regen your protos (probably)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I do that?
Edit: I found out how. In case someone else discovers this comment, I documented how you generate the required Python code from the
*.proto
files in #3390.