-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to anki 24.06.2 and use sveltekit #381
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
c8f64cf
to
6ba5496
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, sorry for the delay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Didn't realize this was ready until you mentioned in Discord, wasn't paying enough attention
@@ -19,7 +19,7 @@ android.useAndroidX=true | |||
android.enableJetifier=false | |||
|
|||
GROUP=io.github.david-allison | |||
VERSION_NAME=0.1.38-anki24.04.1 | |||
VERSION_NAME=0.1.39-anki24.06.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect! will publish after this merges
Anki has switched to ankitects/anki#3077, which now takes care of routing
So now everything is bundled in the
sveltekit
folder instead of having separate pages inaqt/data/web
_app
is renamed toapp
because directories starting with_
are ignored by defaultaaptOptions { ignoreAssetsPattern = "foobar" }
could be used instead of renaming the directory, but that also needs to be done in AnkiDroid, so I opted to just rename it