Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to anki 24.06.2 and use sveltekit #381

Merged
merged 1 commit into from
Jun 15, 2024

Conversation

BrayanDSO
Copy link
Member

@BrayanDSO BrayanDSO commented May 21, 2024

Anki has switched to ankitects/anki#3077, which now takes care of routing

So now everything is bundled in the sveltekit folder instead of having separate pages in aqt/data/web

_app is renamed to app because directories starting with _ are ignored by default

aaptOptions { ignoreAssetsPattern = "foobar" } could be used instead of renaming the directory, but that also needs to be done in AnkiDroid, so I opted to just rename it

@mikehardy

This comment was marked as off-topic.

@BrayanDSO BrayanDSO force-pushed the sveltekit branch 2 times, most recently from c8f64cf to 6ba5496 Compare May 25, 2024 22:27
@BrayanDSO

This comment was marked as outdated.

@voczi

This comment was marked as off-topic.

@david-allison

This comment was marked as off-topic.

@BrayanDSO

This comment was marked as outdated.

@voczi

This comment was marked as outdated.

@BrayanDSO BrayanDSO marked this pull request as ready for review June 9, 2024 09:17
@BrayanDSO BrayanDSO changed the title update to 24.06 and use sveltekit Update to anki 24.06.2 and use sveltekit Jun 9, 2024
@voczi

This comment was marked as outdated.

Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, sorry for the delay!

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Didn't realize this was ready until you mentioned in Discord, wasn't paying enough attention

@@ -19,7 +19,7 @@ android.useAndroidX=true
android.enableJetifier=false

GROUP=io.github.david-allison
VERSION_NAME=0.1.38-anki24.04.1
VERSION_NAME=0.1.39-anki24.06.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect! will publish after this merges

@mikehardy mikehardy merged commit b384ffe into ankidroid:main Jun 15, 2024
6 checks passed
@BrayanDSO BrayanDSO deleted the sveltekit branch June 15, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants