Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow override eventProperties #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow override eventProperties #55

wants to merge 1 commit into from

Commits on Jul 8, 2020

  1. Allow override eventProperties 

    For my particular case I need to pull off the element more properties
than pulled by default (`id`, `className`, `section`). To be more
precise, I want to pull whole `dataset`.

The most straightforward way to do so is overriding `eventProperties`,
which is used in `trackClicks`, `trackSubmits` and `trackChanges`.

However in its current state I can override `trackClick` and others,
but that would be too much of a monkey patch.

I believe making `eventProperties` overridable won't hurt anyone and will
improve the options to customize events data.
    @dmitriy-kiriyenko
    dmitriy-kiriyenko committed Jul 8, 2020
    Configuration menu
    Copy the full SHA
    b0393b6 View commit details
    Browse the repository at this point in the history